Skip to content

correct logic for upper loop limit in chem_diagb#1516

Merged
RussTreadon-NOAA merged 1 commit into
developfrom
bugfix/chem_diagb
Feb 28, 2025
Merged

correct logic for upper loop limit in chem_diagb#1516
RussTreadon-NOAA merged 1 commit into
developfrom
bugfix/chem_diagb

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Feb 27, 2025 •
edited
Loading

Description

This PR modifies the logic used to specify the upper loop limit in the horizontal smoothing section of utils/chem/chem_diagb.h. Less than or equal, <=, is replaced by less than, <

Companion PRs

none

Issues

Resolves #1515

Automated CI tests to run in Global Workflow

  • C96C48_hybatmaerosnowDA

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Feb 27, 2025
@RussTreadon-NOAA RussTreadon-NOAA added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Feb 28, 2025
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Feb 28, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Feb 28, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Fri Feb 28 12:06:38 UTC 2025 on hfe08
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Feb 28 12:48:43 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C48mx500_3DVarAOWCDA|C48mx500_hybAOWCDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Fri Feb 28 14:24:03 UTC 2025
Tests: 100% tests passed, 0 tests failed out of 58

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Feb 28, 2025
andytangborn
andytangborn approved these changes Feb 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@andytangborn andytangborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing this.

@RussTreadon-NOAA RussTreadon-NOAA merged commit c9e6321 into develop Feb 28, 2025
@RussTreadon-NOAA RussTreadon-NOAA deleted the bugfix/chem_diagb branch February 28, 2025 16:39
jspsl pushed a commit that referenced this pull request Mar 26, 2025
@RussTreadon-NOAA @jspsl
correct logic for upper loop limit in chem_diagb (#1516)
6bda4ba
danholdaway added a commit that referenced this pull request Mar 26, 2025
@danholdaway
Merge branch 'develop' into feature/remove_var_name_aliasing
10db435 
* develop:
  added original date (#1570)
  Update OCEAN_BASIN_FILE_ORION path for marine ctest (#1569)
  Fixing window_begin and end in yaml for redating ADT (#1565)
  Save LETKF mean analysis and mean increment for verification (#1566)
  Update JEDI hashes (20250324) (#1567)
  Removes obsolete json files from marine bufr2ioda (#1564)
  Add hybrid 4denvar as a phase3 validation configuration (#1552)
  Bugfix/ocn ecen (#1550)
  Bugfix SSS obs for LETKF (#1560)
  Bugfix ocean ensemble recentering (#1558)
  apply ci path patch only when running g-w ctests (#1554)
  Update JEDI hashes (20250317)  (#1531)
  add option to create_experiment.py in create_exp.sh  (#1546)
  Update jcb hashes and support initial IODA stats capability (#1547)
  Fix GW-CI CTest dependencies (#1534)
  Converts prepoceanobs to use JCB-style obs list and config files (#1527)
  JEDI-based ensemble recentering and analysis calculation (#1488)
  tools for phase3 validation (#1526)
  Update JEDI hashes (20250306) (#1520)
  New jcb-gdas # and insitu obs prep bug fix  (#1523)
  Marine in situ obs update (SSS, moorings, drifters) (#1511)
  Save marine background and analysis spread (#1517)
  Minor build and install updates and ctest cleanup (#1512)
  correct logic for upper loop limit in chem_diagb (#1516)
  Incorporate multi-cycle concatination and separation of variables in post-BUFR observations (#1504)
  Update JEDI hashes (20250225) (#1475)
  Add a depth dependent e-fold scale (#1494)
  Update jcb and da-utils hashes to support land DA. (#1509)
  Add options to inflate the ensemble while recentering (#1501)
  Add components to use jcb yamls for marine letkf job (#1486)
  Add GNSSRO bufr2ioda and json files (#1448)
  Removal of the marine verification tools (#1499)
  update logic to identify MSU machine (#1498)
  IODA Converter with In-Situ Observations Concatenation and ObsError Inflation (#1472)
  Add sea ice recentering (#1478)
  marine vrfy bugfix (#1483)
  add LD_LIBRARY_PATH patch for wcoss2 build (#1484)
  Bugfix for ensemble recenter + add a test (#1477)
  Add code changes for the implementation of the  low-resolution B (#1441)
  update spack-stack path in Hera modulefiles (#1471)
  fixed glider output filename (#1469)
  add gdas_waveinit to C48mx500_3DVarAOWCDA ctest suite (#1470)
  update jcb-gdas hash 20250128 (#1466)
  Time series of omb stats and html doc (#1463)
  Update marine vrfy HTML codes (#1464)
  Automate the verify tools to submit from start pdy to end pdy (#1458)
  Update an offline marine vrfy tool (#1447)
  Update JEDI hashes (20250127) (#1460)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@RussTreadon-NOAA
correct logic for upper loop limit in chem_diagb (#1516)
9245782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andytangborn andytangborn andytangborn approved these changes

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels

hera-GW-RT-Passed Automated testing with global-workflow successful on Hera

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

correct logic for upper loop limit in chem_diagb

3 participants

@RussTreadon-NOAA @emcbot @andytangborn