Skip to content

Add sea ice recentering#1478

Merged
guillaumevernieres merged 2 commits into
developfrom
feature/lowres-b
Feb 7, 2025
Merged

Add sea ice recentering#1478
guillaumevernieres merged 2 commits into
developfrom
feature/lowres-b

Conversation

@guillaumevernieres
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres commented Feb 6, 2025

@guillaumevernieres guillaumevernieres self-assigned this Feb 6, 2025
@guillaumevernieres guillaumevernieres added the hercules-GW-RT Queue for automated testing with global-workflow on Hercules label Feb 6, 2025
@emcbot emcbot added hercules-GW-RT-Running Automated testing with global-workflow running on Hercules and removed hercules-GW-RT Queue for automated testing with global-workflow on Hercules labels Feb 6, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Feb 6, 2025

Automated GW-GDASApp Testing Results:
Machine: hercules

Start: Thu Feb  6 12:34:10 CST 2025 on hercules-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Feb  6 13:09:45 CST 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C48mx500_3DVarAOWCDA|C48mx500_hybAOWCDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Thu Feb  6 13:10:37 CST 2025
Tests: 100% tests passed, 0 tests failed out of 32

@emcbot emcbot added hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules and removed hercules-GW-RT-Running Automated testing with global-workflow running on Hercules labels Feb 6, 2025
# Description

Adds recentering for sea ice by adding the recentering increment to the
sea ice background, and calling Soca2Cice variable change.

Requires copying background files and ice restarts, I wasn't familiar
with how to code this, so please review.

# Companion PRs

Needs a change to global-workflow as well:
guillaumevernieres/global-workflow#10

# Issues

Resolves #1454 

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] atm_jjob <!-- JEDI atm single cycle DA !-->
- [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [ ] C96C48_hybatmaerosnowDA  <!-- JEDI aero/snow cycled DA !-->
- [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->

---------

Co-authored-by: Anna Shlyaeva <anna.v.shlyaeva@noaa.gov>
Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
@guillaumevernieres guillaumevernieres added hercules-GW-RT Queue for automated testing with global-workflow on Hercules and removed hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules labels Feb 6, 2025
@emcbot emcbot added hercules-GW-RT-Running Automated testing with global-workflow running on Hercules and removed hercules-GW-RT Queue for automated testing with global-workflow on Hercules labels Feb 6, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Feb 6, 2025

Automated GW-GDASApp Testing Results:
Machine: hercules

Start: Thu Feb  6 16:05:12 CST 2025 on hercules-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Feb  6 16:40:47 CST 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C48mx500_3DVarAOWCDA|C48mx500_hybAOWCDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Thu Feb  6 16:41:31 CST 2025
Tests: 100% tests passed, 0 tests failed out of 32

@emcbot emcbot added hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules and removed hercules-GW-RT-Running Automated testing with global-workflow running on Hercules labels Feb 6, 2025
@guillaumevernieres guillaumevernieres marked this pull request as ready for review February 7, 2025 13:21
@guillaumevernieres guillaumevernieres changed the title Dummy commit for PR testing Add sea ice recentering Feb 7, 2025
Copy link
Copy Markdown
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so well done 😆

Copy link
Copy Markdown
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine - I had forgotten I had written the original script a year ago!

@guillaumevernieres guillaumevernieres merged commit 7b90ef7 into develop Feb 7, 2025
@guillaumevernieres guillaumevernieres deleted the feature/lowres-b branch February 7, 2025 22:19
danholdaway added a commit that referenced this pull request Mar 26, 2025
* develop:
  added original date (#1570)
  Update OCEAN_BASIN_FILE_ORION path for marine ctest (#1569)
  Fixing window_begin and end in yaml for redating ADT (#1565)
  Save LETKF mean analysis and mean increment for verification (#1566)
  Update JEDI hashes (20250324) (#1567)
  Removes obsolete json files from marine bufr2ioda (#1564)
  Add hybrid 4denvar as a phase3 validation configuration (#1552)
  Bugfix/ocn ecen (#1550)
  Bugfix SSS obs for LETKF (#1560)
  Bugfix ocean ensemble recentering (#1558)
  apply ci path patch only when running g-w ctests (#1554)
  Update JEDI hashes (20250317)  (#1531)
  add option to create_experiment.py in create_exp.sh  (#1546)
  Update jcb hashes and support initial IODA stats capability (#1547)
  Fix GW-CI CTest dependencies (#1534)
  Converts prepoceanobs to use JCB-style obs list and config files (#1527)
  JEDI-based ensemble recentering and analysis calculation (#1488)
  tools for phase3 validation (#1526)
  Update JEDI hashes (20250306) (#1520)
  New jcb-gdas # and insitu obs prep bug fix  (#1523)
  Marine in situ obs update (SSS, moorings, drifters) (#1511)
  Save marine background and analysis spread (#1517)
  Minor build and install updates and ctest cleanup (#1512)
  correct logic for upper loop limit in chem_diagb (#1516)
  Incorporate multi-cycle concatination and separation of variables in post-BUFR observations (#1504)
  Update JEDI hashes (20250225) (#1475)
  Add a depth dependent e-fold scale (#1494)
  Update jcb and da-utils hashes to support land DA. (#1509)
  Add options to inflate the ensemble while recentering (#1501)
  Add components to use jcb yamls for marine letkf job (#1486)
  Add GNSSRO bufr2ioda and json files (#1448)
  Removal of the marine verification tools (#1499)
  update logic to identify MSU machine (#1498)
  IODA Converter with In-Situ Observations Concatenation and ObsError Inflation (#1472)
  Add sea ice recentering (#1478)
  marine vrfy bugfix (#1483)
  add LD_LIBRARY_PATH patch for wcoss2 build (#1484)
  Bugfix for ensemble recenter + add a test (#1477)
  Add code changes for the implementation of the  low-resolution B (#1441)
  update spack-stack path in Hera modulefiles (#1471)
  fixed glider output filename (#1469)
  add gdas_waveinit to C48mx500_3DVarAOWCDA ctest suite (#1470)
  update jcb-gdas hash 20250128 (#1466)
  Time series of omb stats and html doc (#1463)
  Update marine vrfy HTML codes (#1464)
  Automate the verify tools to submit from start pdy to end pdy (#1458)
  Update an offline marine vrfy tool (#1447)
  Update JEDI hashes (20250127) (#1460)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
- Fixes #1454

---------

Co-authored-by: Anna Shlyaeva <annash@ucar.edu>
Co-authored-by: Anna Shlyaeva <anna.v.shlyaeva@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hercules-GW-RT-Passed Automated testing with global-workflow successful on Hercules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recenter sea ice ensembles

4 participants