Skip to content

Add hybrid 4denvar as phase3 validation configuration#1552

Merged
RussTreadon-NOAA merged 22 commits into
developfrom
feature/phase3_validation
Mar 20, 2025
Merged

Add hybrid 4denvar as phase3 validation configuration#1552
RussTreadon-NOAA merged 22 commits into
developfrom
feature/phase3_validation

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

Description

This PR adds a hybrid 4denvar option to the phase3 validation.

Companion PRs

None

Issues

Resolves #1551

Automated CI tests to run in Global Workflow

None of the automated g-w CI tests exercise the changes in this PR. As such, it is not necessary to run g-w based CI.

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Mar 17, 2025
@RussTreadon-NOAA RussTreadon-NOAA added hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion hercules-RT Queue for automated testing on Hercules and removed orion-RT Queue for automated testing on Orion hercules-RT Queue for automated testing on Hercules labels Mar 17, 2025
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Remove Orion and Hercules labels after receiving MSU email informing users that /work2 is currently not available.

@emcbot emcbot added hera-RT-Running Automated testing running on Hera and removed hera-RT Queue for automated testing on Hera labels Mar 17, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Mar 17, 2025

Automated GDASApp Testing Results:
Machine: hera

Start: Mon Mar 17 20:05:33 UTC 2025 on hfe11
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Mar 17 21:07:40 UTC 2025

@emcbot emcbot removed the hera-RT-Running Automated testing running on Hera label Mar 17, 2025
@emcbot emcbot added the orion-RT-Running Automated testing running on Orion label Mar 18, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Mar 18, 2025

Automated GDASApp Testing Results:
Machine: hera

Start: Tue Mar 18 12:09:07 UTC 2025 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Mar 18 12:58:47 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Tue Mar 18 12:59:43 UTC 2025
Tests: 100% tests passed, 0 tests failed out of 32

@emcbot emcbot added hera-RT-Passed Automated testing successful on Hera and removed hera-RT-Running Automated testing running on Hera labels Mar 18, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Mar 18, 2025

Automated GDASApp Testing Results:
Machine: orion

Start: Tue Mar 18 12:41:57 PM UTC 2025 on orion-login-3.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Mar 18 01:55:19 PM UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Tue Mar 18 02:03:45 PM UTC 2025
Tests: 100% tests passed, 0 tests failed out of 32

@emcbot emcbot added orion-RT-Passed Automated testing successful on Orion and removed orion-RT-Running Automated testing running on Orion labels Mar 18, 2025
@RussTreadon-NOAA RussTreadon-NOAA added the hercules-RT Queue for automated testing on Hercules label Mar 18, 2025
@emcbot emcbot added hercules-RT-Running Automated testing running on Hercules and removed hercules-RT Queue for automated testing on Hercules labels Mar 18, 2025
@emcbot
Copy link
Copy Markdown

emcbot commented Mar 18, 2025

Automated GDASApp Testing Results:
Machine: hercules

Start: Tue Mar 18 11:34:03 CDT 2025 on hercules-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Mar 18 12:15:55 CDT 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Tue Mar 18 12:24:26 CDT 2025
Tests: 100% tests passed, 0 tests failed out of 32

@emcbot emcbot added hercules-RT-Passed Automated testing successful on Hercules and removed hercules-RT-Running Automated testing running on Hercules labels Mar 18, 2025
@RussTreadon-NOAA RussTreadon-NOAA changed the title Feature/phase3 validation Add hybrid 4denvar as phase3 validation configuration Mar 18, 2025
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Used ush/ufoeval/setup_phase3.py along with config_gsi.yaml and config_jedi.yaml on Hera to set up and run the four possible DA configurations: 3dv, 3dvfgat, hyb3dvfgat, and hyb4denv. Each configuration ran to completion using both gsi.x and gdas.x.

Repeat this test on Orion. All four configurations ran to completion for gsi.x and gdas.x. Special note: The gdas.x hyb3dvfgat and hyb4denv jobs failed when running 96 tasks on 4 nodes (ppn=24). Change the job script, runjob.sh, to run gdas.x on 8 nodes (ppn=12).

#!/usr/bin/env bash
# Running on orion
#SBATCH --output=runjob.o%J
#SBATCH --account=da-cpu
#SBATCH --qos=debug
#SBATCH --partition=orion
#SBATCH --time=30:00
#SBATCH --nodes=8
#SBATCH --tasks-per-node=12
#SBATCH --cpus-per-task=1
#SBATCH --mem=96Gb

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

This PR is ready for review.

Copy link
Copy Markdown
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (nice that adding the 4DEnVar option required so few changes).

Copy link
Copy Markdown
Collaborator

@DavidNew-NOAA DavidNew-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward. Thanks, Russ

@RussTreadon-NOAA RussTreadon-NOAA merged commit af2182a into develop Mar 20, 2025
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/phase3_validation branch March 20, 2025 12:57
danholdaway added a commit that referenced this pull request Mar 26, 2025
* develop:
  added original date (#1570)
  Update OCEAN_BASIN_FILE_ORION path for marine ctest (#1569)
  Fixing window_begin and end in yaml for redating ADT (#1565)
  Save LETKF mean analysis and mean increment for verification (#1566)
  Update JEDI hashes (20250324) (#1567)
  Removes obsolete json files from marine bufr2ioda (#1564)
  Add hybrid 4denvar as a phase3 validation configuration (#1552)
  Bugfix/ocn ecen (#1550)
  Bugfix SSS obs for LETKF (#1560)
  Bugfix ocean ensemble recentering (#1558)
  apply ci path patch only when running g-w ctests (#1554)
  Update JEDI hashes (20250317)  (#1531)
  add option to create_experiment.py in create_exp.sh  (#1546)
  Update jcb hashes and support initial IODA stats capability (#1547)
  Fix GW-CI CTest dependencies (#1534)
  Converts prepoceanobs to use JCB-style obs list and config files (#1527)
  JEDI-based ensemble recentering and analysis calculation (#1488)
  tools for phase3 validation (#1526)
  Update JEDI hashes (20250306) (#1520)
  New jcb-gdas # and insitu obs prep bug fix  (#1523)
  Marine in situ obs update (SSS, moorings, drifters) (#1511)
  Save marine background and analysis spread (#1517)
  Minor build and install updates and ctest cleanup (#1512)
  correct logic for upper loop limit in chem_diagb (#1516)
  Incorporate multi-cycle concatination and separation of variables in post-BUFR observations (#1504)
  Update JEDI hashes (20250225) (#1475)
  Add a depth dependent e-fold scale (#1494)
  Update jcb and da-utils hashes to support land DA. (#1509)
  Add options to inflate the ensemble while recentering (#1501)
  Add components to use jcb yamls for marine letkf job (#1486)
  Add GNSSRO bufr2ioda and json files (#1448)
  Removal of the marine verification tools (#1499)
  update logic to identify MSU machine (#1498)
  IODA Converter with In-Situ Observations Concatenation and ObsError Inflation (#1472)
  Add sea ice recentering (#1478)
  marine vrfy bugfix (#1483)
  add LD_LIBRARY_PATH patch for wcoss2 build (#1484)
  Bugfix for ensemble recenter + add a test (#1477)
  Add code changes for the implementation of the  low-resolution B (#1441)
  update spack-stack path in Hera modulefiles (#1471)
  fixed glider output filename (#1469)
  add gdas_waveinit to C48mx500_3DVarAOWCDA ctest suite (#1470)
  update jcb-gdas hash 20250128 (#1466)
  Time series of omb stats and html doc (#1463)
  Update marine vrfy HTML codes (#1464)
  Automate the verify tools to submit from start pdy to end pdy (#1458)
  Update an offline marine vrfy tool (#1447)
  Update JEDI hashes (20250127) (#1460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hera-RT-Passed Automated testing successful on Hera hercules-RT-Passed Automated testing successful on Hercules orion-RT-Passed Automated testing successful on Orion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hybrid 4DEnVar option to phase3 validation

5 participants