Add a depth dependent e-fold scale#1494
Merged
Merged
Conversation
guillaumevernieres
requested review from
AndrewEichmann-NOAA,
JohnSteffen-NOAA and
shlyaeva
Contributor
Author
|
I don't think this PR works without the changes in NOAA-EMC/global-workflow#3238 . Keeping as draft for now. |
shlyaeva
reviewed
Feb 12, 2025
Collaborator
shlyaeva
left a comment
shlyaeva
left a comment
There was a problem hiding this comment.
Didn't test, but looks reasonable to me. A couple comments/questions below.
With this change the vertical e-folding scale stays 500 (or vertical e-folding scale) where depth>1500m (or vertical e-folding scale * min efold depth ratio), and switches to depth/3 (depth/min efold depth ratio) otherwise (perhaps except for very shallow water where depth is below min depth), did I read it correct?
Merged
22 tasks
JohnSteffen-NOAA
previously approved these changes
Feb 13, 2025
shlyaeva
previously approved these changes
Feb 14, 2025
guillaumevernieres
dismissed stale reviews from shlyaeva and JohnSteffen-NOAA
via
c3f452a
shlyaeva
previously approved these changes
Feb 14, 2025
Collaborator
shlyaeva
left a comment
shlyaeva
left a comment
There was a problem hiding this comment.
Thank you for addressing my comments, and I'm impressed!
JohnSteffen-NOAA
previously approved these changes
Feb 18, 2025
guillaumevernieres
added
the
hera-GW-RT
guillaumevernieres
added
the
hercules-GW-RT
emcbot
added
hera-GW-RT-Running
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Passed
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hercules-GW-RT-Failed
Contributor
|
MSU Orion and Hercules are experiencing sluggish disk performance. Tickets with the Orion and Hercules help desks were opened earlier this morning (2/21/2025). |
Contributor
Author
|
@RussTreadon-NOAA , it seems that hercules has been having issues for the past few days. I still need to merge things in jcb-gdas and update the # here before I can merge this. I'm still hoping to get to this before cob ... |
6 tasks
guillaumevernieres
dismissed stale reviews from shlyaeva and JohnSteffen-NOAA
via
8a1fda4
guillaumevernieres
added
hera-GW-RT
emcbot
added
hera-GW-RT-Running
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Passed
guillaumevernieres
requested review from
AndrewEichmann-NOAA,
JohnSteffen-NOAA and
shlyaeva
shlyaeva
approved these changes
Feb 21, 2025
jspsl
pushed a commit
that referenced
this pull request
Mar 26, 2025
# Description Not making use of the ensemble spread requires adding a few bells and whistles to the parametric **B**. This PR allows better control of the variance partitioning in shallow places, scaling e-fold to the local depth. _Draft PR until NOAA-EMC/global-workflow#3238 is merged_ # Companion PRs - NOAA-EMC/jcb-gdas#73 # Issues - fixes #1491 # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmaerosnowDA <!-- JEDI aero/snow cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
danholdaway
added a commit
that referenced
this pull request
Mar 26, 2025
* develop: added original date (#1570) Update OCEAN_BASIN_FILE_ORION path for marine ctest (#1569) Fixing window_begin and end in yaml for redating ADT (#1565) Save LETKF mean analysis and mean increment for verification (#1566) Update JEDI hashes (20250324) (#1567) Removes obsolete json files from marine bufr2ioda (#1564) Add hybrid 4denvar as a phase3 validation configuration (#1552) Bugfix/ocn ecen (#1550) Bugfix SSS obs for LETKF (#1560) Bugfix ocean ensemble recentering (#1558) apply ci path patch only when running g-w ctests (#1554) Update JEDI hashes (20250317) (#1531) add option to create_experiment.py in create_exp.sh (#1546) Update jcb hashes and support initial IODA stats capability (#1547) Fix GW-CI CTest dependencies (#1534) Converts prepoceanobs to use JCB-style obs list and config files (#1527) JEDI-based ensemble recentering and analysis calculation (#1488) tools for phase3 validation (#1526) Update JEDI hashes (20250306) (#1520) New jcb-gdas # and insitu obs prep bug fix (#1523) Marine in situ obs update (SSS, moorings, drifters) (#1511) Save marine background and analysis spread (#1517) Minor build and install updates and ctest cleanup (#1512) correct logic for upper loop limit in chem_diagb (#1516) Incorporate multi-cycle concatination and separation of variables in post-BUFR observations (#1504) Update JEDI hashes (20250225) (#1475) Add a depth dependent e-fold scale (#1494) Update jcb and da-utils hashes to support land DA. (#1509) Add options to inflate the ensemble while recentering (#1501) Add components to use jcb yamls for marine letkf job (#1486) Add GNSSRO bufr2ioda and json files (#1448) Removal of the marine verification tools (#1499) update logic to identify MSU machine (#1498) IODA Converter with In-Situ Observations Concatenation and ObsError Inflation (#1472) Add sea ice recentering (#1478) marine vrfy bugfix (#1483) add LD_LIBRARY_PATH patch for wcoss2 build (#1484) Bugfix for ensemble recenter + add a test (#1477) Add code changes for the implementation of the low-resolution B (#1441) update spack-stack path in Hera modulefiles (#1471) fixed glider output filename (#1469) add gdas_waveinit to C48mx500_3DVarAOWCDA ctest suite (#1470) update jcb-gdas hash 20250128 (#1466) Time series of omb stats and html doc (#1463) Update marine vrfy HTML codes (#1464) Automate the verify tools to submit from start pdy to end pdy (#1458) Update an offline marine vrfy tool (#1447) Update JEDI hashes (20250127) (#1460)
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
# Description Not making use of the ensemble spread requires adding a few bells and whistles to the parametric **B**. This PR allows better control of the variance partitioning in shallow places, scaling e-fold to the local depth. _Draft PR until NOAA-EMC/global-workflow#3238 is merged_ # Companion PRs - NOAA-EMC/jcb-gdas#73 # Issues - fixes #1491 # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmaerosnowDA <!-- JEDI aero/snow cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Not making use of the ensemble spread requires adding a few bells and whistles to the parametric B. This PR allows better control of the variance partitioning in shallow places, scaling e-fold to the local depth.
Draft PR until NOAA-EMC/global-workflow#3238 is merged
Companion PRs
Issues
Automated CI tests to run in Global Workflow