Release v2.19.0 #1828

dasanra · 2021-01-29T12:09:39Z

Added

Add option to tweak transaction parameters manually (Advanced options) ( Set transaction parameters manually (advanced) #838 )
Add Unstoppable domain resolutions (.crypto) ( Feature - Add .crypto domain resolution #1764 )
Add dHedge safe app ( Add dHedge Safe App #1706 )
Update Balancer pool management app ( Update Balancer pool management app #1669 )
Update Balancer exchange safe app ( Update Balancer exchange app #1671 )
Update IDLE safe app ( Update Idle Safe App #1718 )
Update 1Inch safe app ( Update 1inch Safe App #1769 )

Fixed

Safe in read-only mode even an owner is connected ( Safe in read-only mode even though correct owner is connected #1685 )
Show a possible fail warning for all transactions in a safe > 2 owners ( Tx marked as "This transaction will most likely fail" even though it doesn't #1804 )
Single tx safe apps interactions shouldn't use multisend ( Single tx safe apps interactions should not use multisend #1791 )
Fix contract interaction with tuples not working ( Contract interaction with tuples not working #1765 )
Fix wallet connect tx failure warning ( WallectConnect - Tx failure warning always shows when you try to sign #1784 )

Chore

Upgrade dependencies

* Use list instead of programmable navigation * move color style to appcard * use color from theme * add declaration for styled-components theme

add data-testid for sidebar add id for recipient field Co-authored-by: Daniel Sanchez <[email protected]> Co-authored-by: Fernando <[email protected]>

Backmerge release v2.18.0 to development

…tion Mergeback hotfix v2.18.1 to development

* Fix checkIfTxIsExecution method implementation * Add tests for checkIfTxIsExecution/checkIfTxIsCreation/checkIfTxIsApproveAndExecution/ * Minimice number of ifs with same result Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: Daniel Sanchez <[email protected]>

* Fix gas estimation for transaction creation * Adds missing logs Co-authored-by: Daniel Sanchez <[email protected]>

…1792) * Don't use multisend if txs.length = 1 * calc txData inside useMemo * fix sending txs from apps, use correct operation/recipient Co-authored-by: Fernando <[email protected]> Co-authored-by: Daniel Sanchez <[email protected]>

* Add dHedge safe app * Disable volta build for all PRs and leave only for release branch and master

* Adds isTupleParameter validation to the extractMethodArgs * Improves tuples parsing * Show examples for txs inputs * Remove MethodsInputExamples Co-authored-by: Mati Dastugue <[email protected]>

* Guard for empty result * Type TextField * Fix warning of InputAdornment in SendFunds modal * Re-enable gas estimation for wallet connect * Replace web3.call on parseRequiredTxGasResponse with axios post to infura * Adds estimateGasWithInfura and estimateGasWithWeb3Provider for changing the estimation method if we are in a non-infura-supported network * Revert calculateMinimumGasForTransaction change to leave the change for the already-open pr * Renames estimateGasWithInfura with estimateGasWithRPCCall Replaces web3 with web3ReadOnly in estimateGasWithRPCCall Co-authored-by: Mati Dastugue <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Daniel Sanchez <[email protected]>

* (Feature) - Support for .crypto resolution * Fix EthereumAddress validator error msg * Extract unstoppable domains logic to an util * Add singleton to UnstoppableDomains instance * Shorten address or domain validation error message Co-authored-by: sudoryan <[email protected]>

github-actions · 2021-01-29T12:09:55Z

CLA Assistant Lite All Contributors have signed the CLA.

mmv08 · 2021-01-29T12:11:08Z

So we're not including the WC app? :(

github-actions · 2021-01-29T12:15:20Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	3	0
Ignored	7	N/A

Result: ✅ success
Annotations: 3 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/logic/wallets/ethTransactions.ts Line 9 - Missing return type on function.
src/logic/wallets/ethTransactions.ts Line 9 - Argument 'hash' should be typed.
src/logic/wallets/utils/unstoppableDomains.ts Line 6 - Missing return type on function.

^{Report generated by eslint-plus-action}

ghost · 2021-01-29T12:35:38Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-01-29T12:49:01Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-01-29T13:03:11Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/volta/app

Co-authored-by: Daniel Sanchez <[email protected]>

ghost · 2021-01-29T16:54:38Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-01-29T17:08:52Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-01-29T17:23:37Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/volta/app

* Makes getGasEstimationTxResponse exportable * Add check for failing txs on approveTxModal * Adds styles for reviewTx * Adds useTxSuccessCheck hook * Remove hook * Adds checkIfTxWillFail function * Uses checkIfTxWillFailAsync on reviewTx modal * Improves approveTx modal * Add check for failing transaction in contract interaction modal * Add check for reviewCollectible * Fix check on sendFunds reviewTx * Adds styling for contractInteraction modal * Fix gas calculation for native token transfers * Remove logs * Rename estimateDataGasCosts to parseRequiredTxGasResponse Adds getPreValidatedSignatures Refactor estimateTxGasCosts Refactor checkIfExecTxWillFail * Refactor checkIfExecTxWill usage * Refactor checkIfTxWillFailAsync in ReviewTx * Use getPreValidatedSignatures in createTransaction() * Refactor estimateTxGasCosts Rename estimateSafeTxGas to estimateExecTransactionGas * Refactor ReviewTx: extract useEffects to hooks * Remove unnecessary gas transfer amount * Refactor estimateTxGasCosts: extract checkIfTxIsExecution and estimateTxGas * Fix tx amount Remove console log * Moves useCheckIfTransactionWillFail to logic/hooks folder * Replaces useEffect usage with useCheckIfTransactionWillFail hook Also fix how some modals fetch the safeAddress * Improves modal's wording * Remove comment * Fix error parsing the cancel transaction error message from GETH nodes * Remove useCheckIfTransactionWillFail Adds useEstimateTransactionGas Renames estimateTxGas to estimateTransactionGas Removes estimateTxGasCosts Removes checkIfExecTxWillFail * Replace useCheckIfTransactionWillFail from modals with useEstimateTransactionGas * Replace estimateGasCosts from every review tx modal with useEstimateTransactionGas * Replace estimateGasCosts from every review tx modal with useEstimateTransactionGas * Extract isExecution calculation to useEstimateTransactionGas * Creates TransactionFailText * Uses TransactionFailText in the review modals * Remove unnecessary styles * Fix imports * Remove css * Fix missing style * Remove duplicated function * Fix modal height * Fix wrong selector usage * Fix missing null check on cancel tx confirmations * Add guard for CLOSE_SNACKBAR action when tx was already dismissed * Improves useEstimateTransactionGas in review custom tx and contract interaction review * Fix hook dependency * Add active screen types in send modal * SafeInfo: replace AddressInfo by EthHashInfo * Fix review replace/remove/add owner modals styling * AdvancedOptions without funcionality * change button text * fix margins and texts * fix close button margin * rename ReviewTx by ReviewSendFundsTx * safe params: partial implementation * make use of useTransactionParameters hook * Refactor response of useEstimateTransactionGas * Remove safeAddress as param to the useEstimateTransactionGas * Improves how threshold is obtained in useEstimateTransactionGas.tsx * Rename gasCostHumanReadable to gasCostFormatted * Add operation to useEstimateTransactionGas * Refactor ConfirmTransactionModal to use useEstimateTransactionGas * Refactor proccessTransaction to use getPreValidatedSignatures method * Fix default export of ApproveTxModal * Rename estimateExecTransactionGas to estimateGasForTransactionCreation Remove estimateTransactionGas from gas.ts * form, accordion, validations * Make estimateGasForTransactionCreation throw error instead of 0 gas * Adds estimateGasForTransactionExecution and estimateGasForTransactionApproval to gas.ts * Move estimateTransactionGas to useEstimateTransactionGas Refactors useEstimateTransactionGas to return isCreation and isOffChainSignature * Add in contractInteraction * review custom TX * review collectible * Type and refactor generateSignaturesFromTxConfirmations Moves getPreValidatedSignatures to safeTxSigner.ts * Uses confirmations to estimateGasForTransactionExecution * Adds TransactionFeesText component Uses TransactionFeesText on ApproveTxModal * Update text * Update text * Remove unnecessary condition * Pass more parameters to estimateGasForTransactionExecution * Removes unnecessary parameter in getNewTxNonce * Moves checkIfOffChainSignatureIsPossible to safeTxSigner.ts * rename AdvancedOptions and add parameters in add owner * replace owner - remove owner * Fix check for null confirmations * Uses checkIfOffChainSignatureIsPossible on createTransaction.ts * Policies * Move TransactionFailText inside TransactionFees component * spending limit * fix textfields gap and margins * fix margins, text size and textfields disposition * Remove unnecessary awaits * Update Accordion comp * Pass safeTxGas to useEstimateTransactionGas.tsx Improves how we use default params * Fix gas iteration on estimateGasForTransactionExecution * Fix estimateGasForTransactionExecution calculation * Fix generateSignaturesFromTxConfirmations calculation * Remove unnecessary Promise and await * Fix estimateGasForTransactionExecution for preApproving owner case * Improve logging * Remove log * Fix typo * merge fixes * Uses operation in useEstimateTransactionGas * Uses operation in useEstimateTransactionGas * add txParameters in ApproveTx * useEstimateTransactionGas add gasPriceFormatted * reviewSendFundsTx gasFormatted * add gasLimit to useEstimateTransactionGas * Files movement - EditParameters refactor * tx parameters in creation * set correct gasPrice * createTx from contractInteraction * Fix gas estimation for transaction creation * disable button while calculating gas * Add owner - reactor and creation options * Add owner: remove unused code * Threshold settings * fix modal ui bug (tx) * fix modal ui bug (settings) * fix modal ui bug (Settings: Policies ) * fix ui bug modal (Spending Limit) * (Fix) - Calculates gas for SpendingLimit transactions (#1773) * Bug: Use link tag instead of javascript navigation in apps list (#1770) * Use list instead of programmable navigation * add declaration for styled-components theme * (Fix) - Calculates gas for SpendingLimit transactions (#1773) * Calculates gas for spendingLimit transactions * Adds TransactionFees component inside UpdateSafeModal * Fix send collectible gas calculation Co-authored-by: Mikhail Mikheev <[email protected]> * speding limits * Remove default exports for spendingLimits * Fix warning in TxParametersDetail * Extracts calculateSpendingLimitsTxData logic and add types * Remove txParameters from setSpendingLimitMultiSendTx/spendingLimitMultiSendTx Adds log for transaction creation success * Refactor handleSubmit, now uses calculateSpendingLimitsTxData to calculate the spendingLimit transaction data before submitting Also calculateSpendingLimitsTxData is used to estimate the amount of gas that the transaction will cost * disable parameters when needed * fix parametersStatus condition * Some fixes * more fixes * send directly when tx nonce == safeNonce * fix tests * parameters in replace owner and remove owner * Fix gas estimation issues for Metamask * FIx Edit transaction parameters src route * Remove default exports RemoveModuleModal * Adds advanced parameters in RemoveModuleModal * Fix css styling of UpdateSafeModal * Adds EditableTxParameters within UpdateSafeModal * Fix warning in <Accordion> for compact parameter * Add advanced settings for RemoveLimitModal.tsx * Fix txNonce usage in RemoveModuleModal.tsx * Remove logs * Fix txNonce param in RemoveLimitModal.tsx * Remove TODOS for refactoring default case of getParametersStatus in EditableTxParameters * Add advanced parameters to Safe apps modal * Force gasPrice and safeTxGas 0 for cancelling transaction * Invert validation of safeTxGas > ethGasLimit, safeTxGas should be < than ethGasLimit * Add missing validation for approveTxModal submit button * Fix checkIfTxIsApproveAndExecution method Add tests * Remove duplication of gas value for calculateGasOf * Fix gas estimation for execution & approval * Adds EXTRA_NODE_GAS for the gasLimit calculation * Revert duplicate of web3.eth.estimateGas * Revert fix of execution & approval * Adds closeEditModalCallback in EditableTxParameters * Accept manual gas price in useEstimateTransactionGas.tsx * Use manualPrice in sendFunds gas estimation * Add safeTxGas estimation to Editable TX Parameters * Set safeTx gasPrice to 0 on tx creation * Refactor useTransactionParameters with initialValues support * Refactor EditableTxParameters.tsx, fixs changing gasLimit or gasPrice * Fix safeTxGas * Add naming to minimum gas required for a transaction * Remove log * Fix nonce calculation for cancel transaction * Update gas estimation to be more precise and avoid reverts * Check that only the creator of the transaction or the executor could modify the advanced parameters * Add validation to submit buttons on modals when the gas estimation is loading * Fix advanced parameters display in change threshold * Fix wrong commit Co-authored-by: Agustin Pane <[email protected]> Co-authored-by: Daniel Sanchez <[email protected]> Co-authored-by: Fernando <[email protected]> Co-authored-by: Agustín Longoni <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]>

ghost · 2021-01-29T20:54:32Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-01-29T21:08:17Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-01-29T21:23:19Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/volta/app

francovenica · 2021-01-30T20:55:36Z

The spending limit estimation is failing to simulate the tx in the backend.

If the tx is submitted anyways MM estimates an amount of gas for the tx

Note: Could it be because the tx is something that doesn't goes through the safe itself.

francovenica · 2021-01-30T21:16:07Z

Naming the owners during the loding of a safe is not working properly. Is being moved 1 address in the review step
See how the address 0x11... is being named "trezr" and then in the step review the name is on the address 0x0dc...
Same happens with the other 2 addresses that were given names

Test by loading this safe: 0x9913B9180C20C6b0F21B6480c84422F6ebc4B808

Note: The issue seems to be only with that safe, maybe because it has a lot of owners (11 owners)

francovenica · 2021-01-30T22:16:29Z

Adding owners is not fully showing the advance parameters. It needs a scroll or force the modal to extend itself
Same issue with "Owner Replacement" and "Owner removal"

ghost · 2021-02-01T11:50:35Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-02-01T12:05:04Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/volta/app

francovenica · 2021-02-01T18:43:23Z

The issue with spending limit is actually expected since the tx goes through the user and not the safe, that's why that happens. We have to tackle it differently
The issue with the names in the Load safe form is already in prod, it seems that it was caused by a fix that didn't got to fix that specific scenario. Is a trivial issue since the user can fix it in the safe settings

ghost · 2021-02-01T22:35:29Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-02-01T22:49:41Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-02-01T23:04:51Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/volta/app

ghost · 2021-02-02T10:56:41Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2021-02-02T11:11:07Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/xdai/app

ghost · 2021-02-02T11:24:23Z

Travis automatic deployment:
https://pr1828--safereact.review.gnosisdev.com/volta/app

mmv08 and others added 19 commits January 13, 2021 17:28

Bug: Use link tag instead of javascript navigation in apps list (#1770)

1a50b59

* Use list instead of programmable navigation * move color style to appcard * use color from theme * add declaration for styled-components theme

Fix asset value column alignment (#1778)

188dc80

Merge branch 'development' into release/v2.18.0

dfc650d

fix ids (#1755)

46274b0

add data-testid for sidebar add id for recipient field Co-authored-by: Daniel Sanchez <[email protected]> Co-authored-by: Fernando <[email protected]>

Merge branch 'development' into release/v2.18.0

d36e447

Merge pull request #1796 from gnosis/release/v2.18.0

8747095

Backmerge release v2.18.0 to development

Merge branch 'development' into hotfix/refund-displayed-as-rejection

3748245

Merge pull request #1807 from gnosis/hotfix/refund-displayed-as-rejec…

5e57368

…tion Mergeback hotfix v2.18.1 to development

(Fix) - Gas estimation for transaction creation (#1772)

a020e8e

* Fix gas estimation for transaction creation * Adds missing logs Co-authored-by: Daniel Sanchez <[email protected]>

Update 1 Inch app to v1.2.3 (#1816)

fef88b0

Update IDLE Safe app (#1813)

57f7acd

Add dHedge safe app (#1821)

621401b

* Add dHedge safe app * Disable volta build for all PRs and leave only for release branch and master

Update balancer pool management app with new keys (#1819)

e3adb24

(Fix) Contract interaction tuples (#1787)

3d43db0

* Adds isTupleParameter validation to the extractMethodArgs * Improves tuples parsing * Show examples for txs inputs * Remove MethodsInputExamples Co-authored-by: Mati Dastugue <[email protected]>

Update balancer exchange app (#1823)

6b4b156

dasanra self-assigned this Jan 29, 2021

dasanra requested a review from francovenica January 29, 2021 12:18

Update WalletConnect app url (#1822)

3415b73

Co-authored-by: Daniel Sanchez <[email protected]>

Set v2.19.0

2bd73c3

alongoni added 2 commits February 1, 2021 16:02

fix 'Advanced options' presentation in modal

4bf1a74

Avoids changing the transaction fee message while loading the estimation

42821c1

Fix multisend enconding when adding a new spender to allowance module

2955985

nicosampler approved these changes Feb 2, 2021

View reviewed changes

dasanra merged commit 2f6113d into master Feb 2, 2021

github-actions bot locked and limited conversation to collaborators Feb 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v2.19.0 #1828

Release v2.19.0 #1828

dasanra commented Jan 29, 2021 •

edited

Loading

github-actions bot commented Jan 29, 2021

mmv08 commented Jan 29, 2021 •

edited

Loading

github-actions bot commented Jan 29, 2021 •

edited

Loading

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

francovenica commented Jan 30, 2021 •

edited

Loading

francovenica commented Jan 30, 2021 •

edited

Loading

francovenica commented Jan 30, 2021 •

edited

Loading

ghost commented Feb 1, 2021

ghost commented Feb 1, 2021

francovenica commented Feb 1, 2021

ghost commented Feb 1, 2021

ghost commented Feb 1, 2021

ghost commented Feb 1, 2021

ghost commented Feb 2, 2021

ghost commented Feb 2, 2021

ghost commented Feb 2, 2021

Release v2.19.0 #1828

Release v2.19.0 #1828

Conversation

dasanra commented Jan 29, 2021 • edited Loading

Added

Fixed

Chore

github-actions bot commented Jan 29, 2021

mmv08 commented Jan 29, 2021 • edited Loading

github-actions bot commented Jan 29, 2021 • edited Loading

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

ghost commented Jan 29, 2021

francovenica commented Jan 30, 2021 • edited Loading

francovenica commented Jan 30, 2021 • edited Loading

francovenica commented Jan 30, 2021 • edited Loading

ghost commented Feb 1, 2021

ghost commented Feb 1, 2021

francovenica commented Feb 1, 2021

ghost commented Feb 1, 2021

ghost commented Feb 1, 2021

ghost commented Feb 1, 2021

ghost commented Feb 2, 2021

ghost commented Feb 2, 2021

ghost commented Feb 2, 2021

dasanra commented Jan 29, 2021 •

edited

Loading

mmv08 commented Jan 29, 2021 •

edited

Loading

github-actions bot commented Jan 29, 2021 •

edited

Loading

francovenica commented Jan 30, 2021 •

edited

Loading

francovenica commented Jan 30, 2021 •

edited

Loading

francovenica commented Jan 30, 2021 •

edited

Loading