You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing web.eth.call as a way for doing the gas estimation, instead now it's using directly an eth_call to infura. The reason it's that depending on the provider implementation the results are different, in some cases, like walletConnecteth_call is not even implemented. I thought that a good way to fix this is just to use our own web3 with infura as provider, but for some reason, if we are using walletConnect the result of the eth_call has no data. So I decided to ignore web3 implementation and use directly infura with a post call.
This is nice because we don't care about the provider.
This will be available only for networks supported by infura, in case that we are in a not-infura-supported network, we do the old estimation.
Also fix some old react warnings like the warning that appears when the sendFunds modal is open
Tested WC with
Regular tx (send funds)
collectibles transfer
Rejecting a tx
Looks good to me, Didn't see the warning message if the tx would succeed. I saw the warning for a Tx builder type of tx that ended up failed (expected outcome)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1784 by:
web.eth.callas a way for doing the gas estimation, instead now it's using directly aneth_callto infura. The reason it's that depending on the provider implementation the results are different, in some cases, likewalletConnecteth_callis not even implemented. I thought that a good way to fix this is just to use our own web3 with infura as provider, but for some reason, if we are usingwalletConnectthe result of theeth_callhas nodata. So I decided to ignore web3 implementation and use directly infura with a post call.old react warningslike the warning that appears when thesendFundsmodal is open