Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Feature - Add .crypto domain resolution #1764

Merged
merged 12 commits into from
Jan 29, 2021

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Jan 11, 2021

  • Adds support for .crypto address resolution
  • Extends resolution functionality from ENS
  • To test locally on rinkeby, use udtestdev--9362ee.crypto and brad.crypto for mainnet

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 11, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 1 0
Ignored 3 N/A
  • Result: ✅ success

  • Annotations: 1 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 11, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 11, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 11, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 11, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 11, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 11, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/volta/app

@dasanra dasanra self-assigned this Jan 11, 2021
@fernandomg
Copy link
Contributor

I'm having this visual issue with the error message overlapping the input text:

image

it happens in the "load safe" form, "create entry" from the address book.

--

I wasn't able to test it with a real .crypto domain. I registered two (udtestdev-fer.crypto, udtestdev-fer-rinkeby.crypto) in rinkeby, but there must be something wrong with the process, because even the unstoppable domain name resolution app is failing to resolve them.

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/volta/app

@dasanra
Copy link
Collaborator Author

dasanra commented Jan 13, 2021

I'm having this visual issue with the error message overlapping the input text:

image

it happens in the "load safe" form, "create entry" from the address book.

--

I wasn't able to test it with a real .crypto domain. I registered two (udtestdev-fer.crypto, udtestdev-fer-rinkeby.crypto) in rinkeby, but there must be something wrong with the process, because even the unstoppable domain name resolution app is failing to resolve them.

Resolved the message issue making it shorter for now

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/volta/app

@francovenica
Copy link
Contributor

The udtestdev--9362ee.crypto name for rinkeby didn't work for me. Is not taking it as a name that can be translated to an address (is like a regular string of characters)

Other names I had worked just fine, like francotest.eth, test.eth, safe.test... All of them worked in the different inputs for addresses.

@francovenica
Copy link
Contributor

It works for me now with the example given in the ticket
"udtestdev--9362ee.crypto"

Tested in
Create safe step2, where you load the addresses
Send funds
Send collectibles
Contract interaction (this example is not a contract so an error is shown, but the address .crypto is being read properly)
Address book entries
Add owner
Replace owner
Spending limit beneficiary

Tested by entering the address by copy/paste and writing it manually
Tested the copy to clipboard and view in blockexplorer links

Looks good to me

@francovenica francovenica self-requested a review January 28, 2021 15:13
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 1 0
Ignored 3 N/A
  • Result: ✅ success

  • Annotations: 1 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 29, 2021

Travis automatic deployment:
https://pr1764--safereact.review.gnosisdev.com/rinkeby/app

@dasanra dasanra merged commit 012b41a into development Jan 29, 2021
@dasanra dasanra deleted the feature/add-crypto-domain-resolution branch January 29, 2021 12:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants