Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) - Gas estimation for transaction creation #1772

Merged
merged 6 commits into from
Jan 26, 2021
Merged

(Fix) - Gas estimation for transaction creation #1772

merged 6 commits into from
Jan 26, 2021

Conversation

Agupane
Copy link
Contributor

@Agupane Agupane commented Jan 13, 2021

Part of #1692

Description

  • Before this PR we weren't doing a good estimation, we didn't take in mind the minimum ETH gas values (21.000)

@Agupane Agupane requested review from fernandomg and dasanra January 13, 2021 15:49
@Agupane Agupane self-assigned this Jan 13, 2021
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 13, 2021 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 14, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 14, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 18, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 18, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/volta/app

@github-actions
Copy link

github-actions bot commented Jan 20, 2021 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 20, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 20, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 26, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 26, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 26, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 26, 2021

Travis automatic deployment:
https://pr1772--safereact.review.gnosisdev.com/volta/app

@Agupane Agupane merged commit a020e8e into development Jan 26, 2021
@Agupane Agupane deleted the fix/creationTxGasEstimation branch January 26, 2021 21:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dasanra dasanra dasanra approved these changes

@matextrem matextrem matextrem approved these changes

@fernandomg fernandomg fernandomg approved these changes

Assignees

@Agupane Agupane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Agupane @fernandomg @matextrem @dasanra