Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Backmerge release v2.18.0 to development #1796

Merged
merged 23 commits into from
Jan 19, 2021
Merged

Backmerge release v2.18.0 to development #1796

merged 23 commits into from
Jan 19, 2021

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Jan 19, 2021

Backmerge latest fixes from v2.18.0 to development

Agupane and others added 21 commits January 14, 2021 12:36
* Bug: Use link tag instead of javascript navigation in apps list (#1770)

* Use list instead of programmable navigation

* add declaration for styled-components theme

* (Fix) - Calculates gas for SpendingLimit transactions (#1773)

* Calculates gas for spendingLimit transactions

* Adds TransactionFees component inside UpdateSafeModal

* Fix send collectible gas calculation

Co-authored-by: Mikhail Mikheev <[email protected]>
Update and fix ledger connection for desktop app
Remove unnecessary useTxAmount
Remove unused build file
* Improves the way we parse the error message on getDataFromNodeErrorMessage for supporting trezor response

* Fix trezor execution not working properly

* Add parameter to processTransaction in ApproveTxModal

Co-authored-by: Daniel Sanchez <[email protected]>
* Make calculateGasOf receive object param

* Disable estimation of gas feature for walletConnect

* Add FIXME to walletConnect estimation check

Co-authored-by: Daniel Sanchez <[email protected]>
@dasanra dasanra self-assigned this Jan 19, 2021
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@dasanra dasanra requested review from Agupane and fernandomg January 19, 2021 18:05
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 3 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Jan 19, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 3 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 19, 2021

Travis automatic deployment:
https://pr1796--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 19, 2021

Travis automatic deployment:
https://pr1796--safereact.review.gnosisdev.com/volta/app

@dasanra dasanra merged commit 8747095 into development Jan 19, 2021
@dasanra dasanra deleted the release/v2.18.0 branch January 19, 2021 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants