-
Notifications
You must be signed in to change notification settings - Fork 362
Bug: Use link tag instead of javascript navigation in apps list #1770
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Travis automatic deployment: |
Travis automatic deployment: |
@@ -15,6 +16,7 @@ const StyledAppCard = styled(Card)` | |||
height: 232px !important; | |||
box-sizing: border-box; | |||
cursor: pointer; | |||
color: ${fontColor}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more question, why can't we use something linke so: ${({ theme }) => theme.colors.background}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot it 😄 a good catch
I also added a declaration for SC theme
Travis automatic deployment: |
Travis automatic deployment: |
This PR:
<a>
tag in apps list because attaching a listener to div is not a good accessibility practice, also it's hard to distinguish between apps when you're developing locally