Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

WallectConnect - Tx failure warning always shows when you try to sign #1784

Closed
francovenica opened this issue Jan 15, 2021 · 1 comment · Fixed by #1806
Closed

WallectConnect - Tx failure warning always shows when you try to sign #1784

francovenica opened this issue Jan 15, 2021 · 1 comment · Fixed by #1806
Assignees
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.

Comments

@francovenica
Copy link
Contributor

Env and safe:
https://pr1771--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0xfcBFa810e2578bB38d8874392a2237Db3b326389/transactions

Issue:
For on chain and off chain tx's. The warning will always show, even when the tx is trivial and is sure to be successful (like a send funds tx)

image.png

@francovenica francovenica added the Bug 🐛 Something isn't working label Jan 15, 2021
@dasanra dasanra added the Major Needs to be fixed for immediate next public release. label Jan 15, 2021
@Agupane Agupane self-assigned this Jan 18, 2021
@Agupane
Copy link
Contributor

Agupane commented Jan 19, 2021

I investigated the issue together with @dasanra and seems that the problem is that WalletConnect does not support eth_call or any read methods. One solution could be to use a hardcoded provider for the estimation given that there is a new issue (#212) that estimates the gas on the transaction service, I'm going to put this on hold to move to that implementation once it's ready

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants