-
Notifications
You must be signed in to change notification settings - Fork 362
Set transaction parameters manually - Advanced options #1760
Conversation
Adds getPreValidatedSignatures Refactor estimateTxGasCosts Refactor checkIfExecTxWillFail
Rename estimateSafeTxGas to estimateExecTransactionGas
Remove console log
Also fix how some modals fetch the safeAddress
…to feature/1048-tx-will-fail-warning
Travis automatic deployment: |
1 similar comment
Travis automatic deployment: |
Should be ok now @francovenica |
Travis automatic deployment: |
Note - Issues 5 and 6 were deleted. I messed up the test giving wrong results The issue 2 was fixed |
Travis automatic deployment: |
…modify the advanced parameters
Travis automatic deployment: |
Issues 1, 4 and 7 where fixed Issue 3 is not critical. We talked how the system should simulate the tx again when you change the parameters, but we decided that includes the "warning message" feature and is too large for this ticket. It will be tackled later |
Closes #838.
Add in all the modals a section to visualize the nonce and gas info for Safe and Ethereum.
Also, allow modifying these values.