Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Set transaction parameters manually - Advanced options #1760

Merged
merged 222 commits into from
Jan 29, 2021
Merged

Conversation

nicosampler
Copy link
Contributor

Closes #838.

Add in all the modals a section to visualize the nonce and gas info for Safe and Ethereum.
Also, allow modifying these values.

Agupane and others added 30 commits November 30, 2020 16:02
Adds getPreValidatedSignatures
Refactor estimateTxGasCosts
Refactor checkIfExecTxWillFail
Rename estimateSafeTxGas to estimateExecTransactionGas
Remove console log
Also fix how some modals fetch the safeAddress
@ghost
Copy link

ghost commented Jan 29, 2021

Travis automatic deployment:
https://pr1760--safereact.review.gnosisdev.com/rinkeby/app

1 similar comment
@ghost
Copy link

ghost commented Jan 29, 2021

Travis automatic deployment:
https://pr1760--safereact.review.gnosisdev.com/rinkeby/app

@Agupane
Copy link
Contributor

Agupane commented Jan 29, 2021

4 - When you reject the tx it shows that it will have a nonce higher than the tx it is creating. The nonce technically is the same of the tx you are rejecting, since the MM popUp shows that nonce, but we have to show it in the review step as well

The nonce is 1 number higher and it should not be for the rejection
image.png

Metamask is receiving the correct nonce
image.png

Should be ok now @francovenica

@ghost
Copy link

ghost commented Jan 29, 2021

Travis automatic deployment:
https://pr1760--safereact.review.gnosisdev.com/rinkeby/app

@francovenica
Copy link
Contributor

Note - Issues 5 and 6 were deleted. I messed up the test giving wrong results

The issue 2 was fixed

@ghost
Copy link

ghost commented Jan 29, 2021

Travis automatic deployment:
https://pr1760--safereact.review.gnosisdev.com/rinkeby/app

@francovenica
Copy link
Contributor

francovenica commented Jan 29, 2021

7 - Modify policies tx is not having the default values in the parameters fields. The tx is being simulated, so that's not the issue.
image.png

@ghost
Copy link

ghost commented Jan 29, 2021

Travis automatic deployment:
https://pr1760--safereact.review.gnosisdev.com/rinkeby/app

@francovenica
Copy link
Contributor

Issues 1, 4 and 7 where fixed

Issue 3 is not critical. We talked how the system should simulate the tx again when you change the parameters, but we decided that includes the "warning message" feature and is too large for this ticket. It will be tackled later

@francovenica francovenica self-requested a review January 29, 2021 20:11
@dasanra dasanra merged commit 2ea67b5 into development Jan 29, 2021
@dasanra dasanra deleted the issue-838 branch January 29, 2021 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set transaction parameters manually (advanced)
7 participants