(Fix) - #1804 Tx gas estimation fail for threshold >= 3

[Agupane]

Closes #1804 by:

• Fixing the checkIfTxIsExecution method to validate that if there is preApprovingOwner: it should also reach the threshold to be considered an executionTransaction and not a transactionApproval
• Add tests

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	1	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1808--safereact.review.gnosisdev.com/rinkeby/app

[ghost]

Travis automatic deployment:
https://pr1808--safereact.review.gnosisdev.com/volta/app

[ghost]

Travis automatic deployment:
https://pr1808--safereact.review.gnosisdev.com/rinkeby/app

[ghost]

Travis automatic deployment:
https://pr1808--safereact.review.gnosisdev.com/volta/app

[matextrem]

LGTM 👍

[ghost]

Travis automatic deployment:
https://pr1808--safereact.review.gnosisdev.com/rinkeby/app

[ghost]

Travis automatic deployment:
https://pr1808--safereact.review.gnosisdev.com/volta/app

[francovenica]

Env and safe: https://pr1808--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/transactions

I've checked myself setting a safe with 3 owners needed to sign (I assume 4 or more is the same situation as 3, since after the first one and before the last one the system is collecting signatures and that's what it was failing)

Tested with MM and a trezor:

Send funds
Send collectibles
Custom transaction (A Dai tx with the ERC20 contract methods)
An app tx (compound withdrawal)
Change in the settings (modify policies)
A tx rejection

Checked with 2 owners it still works fine:
Send funds
App tx
A tx rejection

I forced the warning message to show up by queuing 2 tx that executing the first would made fail the second. It worked fine as well

[ghost]

Travis automatic deployment:
https://pr1808--safereact.review.gnosisdev.com/rinkeby/app

[ghost]

Travis automatic deployment:
https://pr1808--safereact.review.gnosisdev.com/volta/app