Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Feature: Update walletconnect app #1822

Merged
merged 4 commits into from
Jan 29, 2021
Merged

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jan 27, 2021

New things in wc app:

Testing it would be just making sure everything works as before. I'm not sure about a way to test multi_send/eth_sign besides custom app, @rmeissner correct if I'm wrong

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 27, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 27, 2021

Travis automatic deployment:
https://pr1822--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 27, 2021

Travis automatic deployment:
https://pr1822--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 27, 2021

Travis automatic deployment:
https://pr1822--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 28, 2021

Travis automatic deployment:
https://pr1822--safereact.review.gnosisdev.com/rinkeby/app

@francovenica
Copy link
Contributor

Wallet connect is not loading. I've waited for 10 mins and it never loaded

image.png

@mmv08
Copy link
Member Author

mmv08 commented Jan 28, 2021

@francovenica could you please try again?

@francovenica
Copy link
Contributor

Yes, it works now
Tried with WC Example
image

@ghost
Copy link

ghost commented Jan 29, 2021

Travis automatic deployment:
https://pr1822--safereact.review.gnosisdev.com/rinkeby/app

@dasanra dasanra merged commit 3415b73 into development Jan 29, 2021
@dasanra dasanra deleted the feature/update-wc-app branch January 29, 2021 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants