-
Notifications
You must be signed in to change notification settings - Fork 362
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
…to fix/contract-interaction-tuples
ESLint Summary View Full Report
Report generated by eslint-plus-action |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Travis automatic deployment: |
Travis automatic deployment: |
Travis automatic deployment: |
Travis automatic deployment: |
Travis automatic deployment: |
src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/utils/index.ts
Show resolved
Hide resolved
Travis automatic deployment: |
Travis automatic deployment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Agupane, left some comments.
It works fine, what do you think about adding a helper snippet like the one used in the TransactionBuilder sApp?
src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/Header/index.tsx
Outdated
Show resolved
Hide resolved
...tes/safe/components/Balances/SendModal/screens/ContractInteraction/MethodsDropdown/index.tsx
Outdated
Show resolved
Hide resolved
if (!valid || !abi || abi === NO_CONTRACT) { | ||
return null | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
...ts/Balances/SendModal/screens/ContractInteraction/RenderInputParams/InputComponent/index.tsx
Outdated
Show resolved
Hide resolved
...s/safe/components/Balances/SendModal/screens/ContractInteraction/RenderInputParams/index.tsx
Outdated
Show resolved
Hide resolved
.../safe/components/Balances/SendModal/screens/ContractInteraction/RenderOutputParams/index.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/utils/index.ts
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/utils/index.ts
Show resolved
Hide resolved
ESLint Summary View Full Report
Report generated by eslint-plus-action |
…to fix/contract-interaction-tuples
Good idea, I implemented it @fernandomg |
Travis automatic deployment: |
Travis automatic deployment: |
😁 |
Ok, this was confusing to test until I read the contract itself, the one provided in the issue Technically a "tuple" is a collection of values, that can be any type of values and any amount of values, but in this case it seems that the contract expect a specific tuple to be introduced depending on the function you use, so is not just "enter a tuple of what ever you want" but the specific tuple the contract expect, so maybe the placeholder should always indicate what those values should be, but I think the placeholder is on the contract side, not in our side. For that contract in specific the tuples are: So I tried all 3 examples and it worked fine |
Travis automatic deployment: |
1 similar comment
Travis automatic deployment: |
Closes #1765 by: