Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) Contract interaction tuples #1787

Merged
merged 14 commits into from
Jan 27, 2021
Merged

Conversation

Agupane
Copy link
Contributor

@Agupane Agupane commented Jan 18, 2021

Closes #1765 by:

  • Parsing the input as a JSON string to turn it into an array

@Agupane Agupane self-assigned this Jan 18, 2021
@Agupane Agupane added the WIP label Jan 18, 2021
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Jan 18, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 18, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 18, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 18, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/volta/app

@Agupane Agupane marked this pull request as ready for review January 19, 2021 14:21
@Agupane Agupane removed the WIP label Jan 19, 2021
@ghost
Copy link

ghost commented Jan 22, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 22, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Jan 25, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 25, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/volta/app

Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agupane, left some comments.

It works fine, what do you think about adding a helper snippet like the one used in the TransactionBuilder sApp?

image

Comment on lines +70 to +72
if (!valid || !abi || abi === NO_CONTRACT) {
return null
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@github-actions
Copy link

github-actions bot commented Jan 26, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@Agupane
Copy link
Contributor Author

Agupane commented Jan 26, 2021

@Agupane, left some comments.

It works fine, what do you think about adding a helper snippet like the one used in the TransactionBuilder sApp?

image

Good idea, I implemented it @fernandomg

@ghost
Copy link

ghost commented Jan 26, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 26, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/volta/app

@fernandomg fernandomg closed this Jan 26, 2021
@fernandomg fernandomg reopened this Jan 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
@fernandomg
Copy link
Contributor

😁

@fernandomg fernandomg self-requested a review January 26, 2021 22:38
@5afe 5afe unlocked this conversation Jan 27, 2021
@francovenica
Copy link
Contributor

Ok, this was confusing to test until I read the contract itself, the one provided in the issue
https://rinkeby.etherscan.io/address/0x36292b627eb637696c90edd460e49300b099d045#code

Technically a "tuple" is a collection of values, that can be any type of values and any amount of values, but in this case it seems that the contract expect a specific tuple to be introduced depending on the function you use, so is not just "enter a tuple of what ever you want" but the specific tuple the contract expect, so maybe the placeholder should always indicate what those values should be, but I think the placeholder is on the contract side, not in our side.

For that contract in specific the tuples are:
func1: [uint16, uint16]
func2: [address, uint16]
func3: [address, address]

So I tried all 3 examples and it worked fine
https://pr1787--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x4B1b5434168e37C3af3c32Ed176E07Cdd02f3cA0/transactions

@ghost
Copy link

ghost commented Jan 27, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/rinkeby/app

1 similar comment
@ghost
Copy link

ghost commented Jan 27, 2021

Travis automatic deployment:
https://pr1787--safereact.review.gnosisdev.com/rinkeby/app

@dasanra dasanra merged commit 3d43db0 into development Jan 27, 2021
@dasanra dasanra deleted the fix/contract-interaction-tuples branch January 27, 2021 22:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract interaction with tuples not working
5 participants