Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix ids #1755

Merged
merged 4 commits into from
Jan 19, 2021
Merged

Fix ids #1755

merged 4 commits into from
Jan 19, 2021

Conversation

francovenica
Copy link
Contributor

add data-test-id for sidebar

add id for recipient field

add data-testid for sidebar

add id for recipient field
@github-actions
Copy link

github-actions bot commented Jan 6, 2021

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 6, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 6, 2021

Travis automatic deployment:
https://pr1755--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 6, 2021

Travis automatic deployment:
https://pr1755--safereact.review.gnosisdev.com/volta/app

@francovenica francovenica marked this pull request as ready for review January 8, 2021 20:26
@mmv08
Copy link
Member

mmv08 commented Jan 12, 2021

Why does the sidebar need an id? It's using aside HTML tag which is unique on the page

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1755--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1755--safereact.review.gnosisdev.com/volta/app

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 19, 2021

Travis automatic deployment:
https://pr1755--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 19, 2021

Travis automatic deployment:
https://pr1755--safereact.review.gnosisdev.com/volta/app

@francovenica francovenica merged commit 46274b0 into development Jan 19, 2021
@francovenica francovenica deleted the Automation branch January 19, 2021 18:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2021
@mmv08
Copy link
Member

mmv08 commented Jan 19, 2021

Why does the sidebar need an id? It's using aside HTML tag which is unique on the page

Bump

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants