Merged
Conversation
**Why**: Streamlines common oncall task of checking for email bounces changelog: Internal, Scripts, Add script to debug email deliveries
* LG-9449: Implement and configure ArcGIS API token refresh job changelog: Internal, In-person proofing, Refresh ArcGIS token in job * LG-9449: Move cron expression to config
* Add log filename to logs to disambiguate in STDOUT changelog: Internal, Logging, Add log filename to logs to disambiguate in STDOUT * add frozen_string_literal * remove rails.log
Disable the IfUnlessModifier because it is annoying [skip changelog]
* Update JSDOM & ESLint to resolve security advisory changelog: Internal, Dependencies, Update dependencies to resolve security advisories * Downgrade JSDOM * Deduplicate * Re-bump optionator * Upgrade JSDOM * Fix form stubbing submit * FormStepsWait: Use dependency injection for navigate behavior * webauthn-setup: Use dependency injection for navigate behavior * form-link: Stub form submission directly * form-steps-wait: Fix type errors * Remove word-wrap exception * Restore original behavior with location search assignment * Pass full URL to navigate in reloadWithError * Consolidate URL parsing / initialization * typescript would have saved us this mistake
* normalize-yaml: Prepare for NPM publish changelog: Internal, JavaScript Packages, Publish normalize-yaml package to NPM * Use common version of yaml dependency * Try TypeScript declaration build
* changelog: User-Facing Improvements, Bug Fixes, Remove display of failed authentication message after successful retry to authenticate * add test coverage for webauthn signin errors * move new test case to the end of the spec file * fix mis-nested new 'it' block * fix lint errors * fix typo in spec and refactor element selection in ts file * add Non-null assertion operator to alert container
We have migrated from the v2 encryptor to the v3 encryptor so the v2 encryptor can be safely retired. changelog: Internal, Session encryption, The v2 session encryptor was removed in favor of the v3 session encryptor.
We implemented a version of a multi-region KMS client. It was intended to encrypt across multiple regions so that if a region was unavailable a ciphertext could be decrypted in a different region. This code was never enabled due to complications with configuring the KMS clients. Since this implementation was put together AWS has released KMS instances that are multi-region. This means we no longer need to use this approach to encrypt/decrypt across regions. As a result, this code can be removed. [skip changelog]
* test kaniko cache changelog: Internal, Continuous Integration, Cache image layers when building review application images * try disabling compressed caching * try cache repo * use the new repo * add cache ttl of one week
) * Don't use doc_auth return_to_sp route in state_id_warning page changelog: Internal, Identity verification, remove doc_auth_controller and doc_auth_flow * PersonalKeyController: idv_doc_auth_url -> idv_review_url * GpoController: idv_doc_auth_url -> idv_verify_info_url * Replace doc_auth_controller actions with logging and redirects This way we'll know if any of them are still used. * Remove DocAuthFlow and spec helper * Cleanup: remove unused verify_wait analytics events And an incorrect previous_event_name comment * Remove idv_doc_auth_step_url from specs It was unused in _document_capture.html.erb_spec Replaced with idv_in_person_step_url in _back.html_erb_spec since that's still in use. * Test referer logging, rename log_visit -> log_unexpected_visit to make it clearer that this is temporary code.
* use transaction_with_timeout method * Add changelog changelog: Improvements, Reporting, add timout so report will run
changelog: Internal, Reporting, Report on account creation and deletion rates
…8702) * LG-9449: Configure ArcGIS token job to respect mock geocoder setting * [skip changelog]
…e MFA (#8597) * changelog: User-Facing Improvements, authentication improvements, add confirmation prompt for backup codes setup * add view, copy to skeleton view * additional translations, layout of view * more layout work * add redirect for backup codes setup * protect from going back to screen if authenticated * change redirect to happen in confirmation screen on skip * fix logic to only redirect for backup code setup * add test for skip for now option * change redirect to second mfa path * fix multiple mfa sign up spec * edit sign up spec test * lint fix * edit test for redirect after backup code setup * fix error test wrt app name; edit translation * dynamically load app name in text * edit test for MFA cta banner * WIP: check for setup and other codes setup * fix bug to redirect when method is already set up * add good test * remove method * remove unused method * remove test * Address PR comment: refactor method and remove extra method * add tests * lint fix * remove unnecessary margins and borders * adjust margins a little bit * Update app/views/users/backup_code_setup/confirm_backup_codes.erb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * rename confirm backup codes view * lint fix * set up buttons in grid * Update app/views/users/backup_code_setup/confirm_backup_codes.html.erb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * lint fix * Update spec/features/users/sign_up_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * add helper for backup code confirmation click * remove uneeded spec * update test * fix page footer link * fix button width * remove uneeded class from sass file * make buttons full width * lint fixes * Update app/views/users/backup_code_setup/confirm_backup_codes.html.erb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update config/locales/two_factor_authentication/en.yml Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * add html to key * fix english key --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* LG-9381: Remove code for OTP expiration redirect [skip changelog] * Use ActiveSupport helper for time distance Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Delete otp_expired_controller_spec.rb --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Add new data model and db table for notifications * Add spec for new model * changelog: Upcoming Features, In Person Notifications, Add data model for sms notifications * Make phone number non-nullable and remove sent_at * Make index unique * Move duplicate code into PhoneLib helper * Add basic masking specs to PhoneFormatter
* LG-10110: Delete Attempts API encryption code [skip changelog] * lint * feedback * fixes * feedback * removing event build * cleanup * more cleanup
* Test profile and active_profile before and after * Set up for active factory use * Use active profile factory * Correction: `activated_at` remains not nil * changelog: Internal, Testing, Add tests for profile activation/deactivation * Use profile factory in profile spec * Test before and after activate in reproof spec also: - use active profile factory - replace double negatives with positive checks * Activate rather than update single field * Test fields before and after activation * Test `Profile#has_proofed_before?` explicitly before and after activation * Mark unchanged field * Use profile factory * Test both profiles before and after activation * Test `Profile#has_proofed_before?` before and after * Removed `activated_at` from `active` trait * Shorten lines * Remove trailing whitespace * Document spec that relies on the wrong profile field TODO: target new `active` trait on profile factory * Test user's profiles * Use profile factory with verified, active traits * Material spec still passes without active profile under new active trait * Name test objects better * Test activating a non-active profile TODO: this change accounts for the following non-active profile scenarios: - deactivated - password_reset - encryption_error There may also be other possible non-active scenarios. * Test activate in reproof spec * Test activate raise error * Create and use verify_by_mail profile * Test prevent activate on a fraud pending profile * Use fraud review pending factory * Test prevent activate of fraud rejection profile * Use fraud rejection factory * Move initialize and deactivate all to it block * Test deactivation * Test around remove gpo deactivation reason * Use verify_by_mail_pending profile factory * Prefer parens around eq calls * Test prevent activate after password reset if profile has pending reason TODO: should this method nil out deactivation_reason even though it raises an error? * Test around activate after password reset * Use password_reset and verified profile factory * Test activate on IPP * Use fraud pending, IPP profile factory * Test around activate after IPP * Test activate after passing review * Use profile factories * Test deactivate for verify by mail * Note possible action items * Test deactivate for fraud review * Remove `/sign_up/completed` routes to see what fails * Delete `SignUp::CompletionsController` and spec * Revert "Delete `SignUp::CompletionsController` and spec" This reverts commit 9d30a93. * Revert "Remove `/sign_up/completed` routes to see what fails" This reverts commit 2dcc5e8. * Mark where a profile is being activated mistakenly This spec should expect a raised exception * Update comments TODOs: - call activate on 215 - remove `has_proofed_before` describe block - 324 should also be `verified` - 357 should store `activated_at` * Add comments add 1 TODO and clarify another * Don't call unsupported method in unused spec for unused controller * Restore `activated_at` to `active` trait * Rename local variables, account for present activated_at from new factory
* fix `_html` on keys * fix spec [skip changelog] * [skip changelog] * modify I need new backup codes test * Update spec/features/two_factor_authentication/multiple_mfa_sign_up_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* cancel stale enrollments on doc capture update changelog: Bug Fixes, In-person proofing, cancel establishing enrollments on visiting doc capture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features