Update JSDOM & ESLint to resolve security advisory#8677
Merged
Conversation
mitchellhenke
approved these changes
Jun 28, 2023
Contributor
Author
|
Upgrading JSDOM will require more work due to some issues with how we manipulate |
Contributor
Author
|
Actually, that might not be true, since |
changelog: Internal, Dependencies, Update dependencies to resolve security advisories
e384a2b to
494afd2
Compare
Contributor
Author
|
I managed to work through the JSDOM upgrade, mostly by using a dependency injection approach to parameterizing the redirect logic as an alternative to stubbing the window values directly. This should be ready for another review. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates JSDOM & ESLint dependencies (and subdependencies) to resolve a security advisory related to the
word-wrapdependency.Upgrading the top-level dependencies was enough to resolve JSDOM. Upgrading ESLint did not automatically force an update to its
optionatordependency, whereoptionator@0.9.3swaps the offending package with an alternative, patched version. Removing theoptionatorblock fromyarn.lockand rerunningyarn installwas enough to force the update.📜 Testing Plan
The
audit_yarn_packageexits with a successful exit code: