LG-9449: Configure ArcGIS token job to respect mock geocoder setting

[NavaTim]

🎫 Ticket

• LG-9449

🛠 Summary of changes

• Update the ArcGIS token job to respect the mock geocoder setting

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Configure environment to use the mock geocoder
• Verify that no calls are made to ArcGIS and that no related errors occur

[zachmargolis]

proposal:

1. call this a Router to match our DocAuthRouter
2. make it a module, or at least ditch the instance method, there's nothing really to instantiate here because there's no state?

Suggested change

	class GeocoderFactory
	def create
	if IdentityConfig.store.arcgis_mock_fallback
	ArcgisApi::Mock::Geocoder.new
	else
	ArcgisApi::Geocoder.new
	end
	end
	end
	module GeocoderRouter
	module_function
	def geocoder
	if IdentityConfig.store.arcgis_mock_fallback
	ArcgisApi::Mock::Geocoder.new
	else
	ArcgisApi::Geocoder.new
	end
	end
	end

so callsites would look like:

ArcgisApi::GeocoderRouter.geocoder

[gina-yamada]

Everything looks good in here. I like this suggestion.

[NavaTim]

This is a factory pattern, so using Factory in the name makes more sense and is more informative to developers who aren't as familiar with this specific codebase. The Router naming is confusing because that is normally associated with routing web requests to a controller.

[NavaTim]

I thought about making this a module, but based on my prior experience using an instance tends to be more useful and reusable. The decision does seem a little arbitrary without more established conventions around IoC though.

[zachmargolis]

bonus to switching to a class/module method: we don't need to stub :new (which is one of my biggest pet peeves)