Conversation
mitchellhenke
approved these changes
Jul 3, 2023
jmdembe
force-pushed
the
bug_fix_confirm_backup_codes_text
branch
from
3ca05cf to
ef62aa7
Compare
aduth
approved these changes
Jul 3, 2023
zachmargolis
reviewed
Jul 3, 2023
| safe. If you lose your backup codes, you won’t be able to sign into | ||
| %{app_name}. | ||
| new_backup_codes: I need new backup codes | ||
| new_backup_codes_html: I need new backup codes |
Contributor
There was a problem hiding this comment.
this feels like something we can lint on to detect! I will noodle on some ideas
jmdembe
commented
Jul 3, 2023
spec/features/two_factor_authentication/multiple_mfa_sign_up_spec.rb
Outdated
Show resolved
Hide resolved
…pec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ticket is a bug fix--users will no longer see
on the English "I need new backup codes" buttonBefore
After
