Adding in allow_failure for review stage to not disrupt CI checks#8693
Merged
stephencshelton merged 1 commit intomainfrom Jun 29, 2023
Merged
Adding in allow_failure for review stage to not disrupt CI checks#8693stephencshelton merged 1 commit intomainfrom
stephencshelton merged 1 commit intomainfrom
Conversation
mitchellhenke
approved these changes
Jun 29, 2023
stephencshelton
force-pushed
the
sshelton/add-retry-optional
branch
from
acc1d3d to
c57dacc
Compare
stephencshelton
changed the title
stephencshelton
force-pushed
the
sshelton/add-retry-optional
branch
from
c57dacc to
7542aa6
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says
Does what it says, adds allow_failure to the review-app stage. Tested to see when the helm chart would lock and how long it took and decided against adding the retry in to the helm upgrade command since it wouldn't help with actual failures and would just draw the failure out longer.