LG-9939 Remove (most of) DocAuthController and all of DocAuthFlow#8699
Merged
soniaconnolly merged 8 commits intomainfrom Jun 30, 2023
Merged
Conversation
changelog: Internal, Identity verification, remove doc_auth_controller and doc_auth_flow
This way we'll know if any of them are still used.
And an incorrect previous_event_name comment
It was unused in _document_capture.html.erb_spec Replaced with idv_in_person_step_url in _back.html_erb_spec since that's still in use.
jmhooper
reviewed
Jun 30, 2023
jmhooper
reviewed
Jun 30, 2023
| @@ -1,29 +0,0 @@ | |||
| module Idv | |||
jmhooper
approved these changes
Jun 30, 2023
to make it clearer that this is temporary code.
soniaconnolly
deleted the
sonia-lg-9939-remove-doc-auth-controller-and-flow
branch
This was referenced Jun 30, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9939
🛠 Summary of changes
Replace DocAuthController and specs with logging in case routes get used anywhere. (Plan is to remove the controller & spec completely in a followup PR)
Remove DocAuthFlow
Remove uses of idv_doc_auth_return_to_sp_url and idv_doc_auth_url
Fix specs
Bonus cleanup: remove unused verify_wait analytics events.
📜 Testing Plan