Add log filename to logs to disambiguate in STDOUT#8610
Merged
mitchellhenke merged 3 commits intomainfrom Jun 29, 2023
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/disambiguate-logs
branch
2 times, most recently
from
08d586b to
9b2081b
Compare
mitchellhenke
force-pushed
the
mitchellhenke/disambiguate-logs
branch
3 times, most recently
from
ec14ed2 to
e80855f
Compare
mitchellhenke
force-pushed
the
mitchellhenke/disambiguate-logs
branch
2 times, most recently
from
ed8ec15 to
84975f5
Compare
mitchellhenke
force-pushed
the
mitchellhenke/disambiguate-logs
branch
2 times, most recently
from
5d8f197 to
2b36288
Compare
added 3 commits
June 29, 2023 11:12
changelog: Internal, Logging, Add log filename to logs to disambiguate in STDOUT
mitchellhenke
force-pushed
the
mitchellhenke/disambiguate-logs
branch
from
2b36288 to
425caca
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We are experimenting with logging all logs to STDOUT in containers, and ensuring they end up in the right log groups in CloudWatch requires a way to disambiguate the lines from one another.
The one that is TBD is the Rails logs, which will likely be our fallback case and may not need the additional metadata.