LG-9951: Add confirmation prompt when user selects backup code as sole MFA#8597
Merged
LG-9951: Add confirmation prompt when user selects backup code as sole MFA#8597
Conversation
… confirmation prompt for backup codes setup
jmdembe
force-pushed
the
LG-9951-backup-codes-warning
branch
from
a43ee62 to
2b1c5ee
Compare
jmdembe
force-pushed
the
LG-9951-backup-codes-warning
branch
from
2b1c5ee to
95eca8c
Compare
jmdembe
force-pushed
the
LG-9951-backup-codes-warning
branch
from
f70a813 to
7079f51
Compare
aduth
reviewed
Jun 26, 2023
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
aduth
reviewed
Jun 27, 2023
| expect(page).to have_current_path(confirm_backup_codes_path) | ||
| click_link t('two_factor_authentication.backup_codes.saved_backup_codes') | ||
|
|
||
| click_agree_and_continue |
Contributor
There was a problem hiding this comment.
I'm not sure if the click_agree_and_continue was meaningful in testing anything previously, but we lost it in the revisions here. Should it be added back?
Contributor
Author
There was a problem hiding this comment.
Based on what I understood, it did not seem to be meaningful. If I am missing something, I would be more than happy to include it back in
aduth
reviewed
Jun 27, 2023
app/views/users/backup_code_setup/confirm_backup_codes.html.erb
Outdated
Show resolved
Hide resolved
app/views/users/backup_code_setup/confirm_backup_codes.html.erb
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
aduth
approved these changes
Jun 30, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Looks great! 👍 Couple comments, but should either be quick or non-blocking.
app/views/users/backup_code_setup/confirm_backup_codes.html.erb
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9951: Add confirmation prompt when user selects backup code as sole MFA
🛠 Summary of changes
This PR asks users to confirm that they have saved their backup codes before completing the signup process
📜 Testing Plan
On localhost:3000
👀 Screenshots