LG-10218 Retire the v2 session encryptor#8687
Merged
Conversation
We have migrated from the v2 encryptor to the v3 encryptor so the v2 encryptor can be safely retired. changelog: Internal, Session encryption, The v2 session encryptor was removed in favor of the v3 session encryptor.
Contributor
Author
|
To ensure environments that have not had the v3 encryptor enabled do not encounter issues this change should go 1 release cycle behind #8686. For reference, production and int both have the v3 encryptor enabled. Staging does not. |
jmhooper
commented
Jun 28, 2023
| @@ -3,210 +3,172 @@ | |||
| RSpec.describe SessionEncryptor do | |||
Contributor
Author
There was a problem hiding this comment.
I recommend the "Hide whitespace" setting for reviewing this file.
mitchellhenke
approved these changes
Jun 28, 2023
zachmargolis
approved these changes
Jun 28, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, super simple diff w/ whitespace hidden
jmhooper
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have migrated from the v2 encryptor to the v3 encryptor so the v2 encryptor can be safely retired.