LG-10201: cancel stale enrollments on doc capture visit#8712
Merged
tomas-nava merged 2 commits intomainfrom Jul 3, 2023
Merged
LG-10201: cancel stale enrollments on doc capture visit#8712tomas-nava merged 2 commits intomainfrom
tomas-nava merged 2 commits intomainfrom
Conversation
changelog: Bug Fixes, In-person proofing, cancel establishing enrollments on visiting doc capture
soniaconnolly
approved these changes
Jul 3, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM, with some of the future work we discussed.
Contributor
|
LGTM |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10201
🛠 Summary of changes
Cancels any 'establishing' in-person enrollments when the document capture page is submitted. This fixes a bug where the progressive proofer was trying to follow the double address verification flow even though the user was verifying remotely, because they'd previously begun the in-person flow and then started over.
📜 Testing Plan
Once the change is on staging,
go to staging and create an account via the OIDC app;
fail doc capture & start down the in-person flow, get as far as selecting a location and loading the state ID page;
return to doc capture (do not click 'cancel'); you can do this by taking one of the below actions:
/verifysuccessfully pass doc capture & continue the remote verification flow;
confirm that you are able to verify successfully