Merged
Conversation
Contributor
Author
|
Something we should figure out how to do is get TypeScript types ( |
aduth
force-pushed
the
aduth-prepare-normalize-yaml-publish
branch
from
048949d to
3f5e904
Compare
Contributor
Author
|
I gave this a quick try in It might be nice to support glob patterns as an argument vs. the current brace expansion / explicit paths approach, but fine to save that for a future enhancement. |
aduth
force-pushed
the
aduth-prepare-normalize-yaml-publish
branch
from
3f5e904 to
a4f4682
Compare
changelog: Internal, JavaScript Packages, Publish normalize-yaml package to NPM
aduth
force-pushed
the
aduth-prepare-normalize-yaml-publish
branch
from
a4f4682 to
14400c9
Compare
Contributor
Author
|
Published at https://www.npmjs.com/package/@18f/identity-normalize-yaml 🚀 |
aduth
commented
Jun 30, 2023
|
|
||
| - Alphabetizes keys. | ||
| - Applies improved punctuation. | ||
| - Converts straight quotes `"` and `'` to smart quotes `“`, `”`, and `’` |
Contributor
Author
There was a problem hiding this comment.
Of course I'm realizing after publishing that this should have included the left form of the single smart quote ‘ 🤦
Suggested change
| - Converts straight quotes `"` and `'` to smart quotes `“`, `”`, and `’` | |
| - Converts straight quotes `"` and `'` to smart quotes `“`, `”`, `‘`, and `’` |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Adds details to the
@18f/identity-normalize-yamlpackage to prepare for publish to NPM:package.jsondetailsWhy?
📜 Testing Plan
There should be no impact on the IdP usage.
You could test that
npm publish --dry-runoutputs the expected result for a published artifact.