LG-9449: Implement and configure ArcGIS API token refresh job

[NavaTim]

🎫 Ticket

• LG-9449

🛠 Summary of changes

• Create scheduled job to refresh ArcGIS token regularly before it expires
  • Cron is configurable because while the default expiration is 1 hour, the server can use a different value.

This intentionally excludes the retry and sliding window logic that was attempted in #8662 and #8579. These features can help with availability, but they contribute enough complexity that it doesn't make sense to shoehorn them into the same story.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Deploy with job enabled
• Wait for job window to pass
• Check that analytics shows job logs
• Check that analytics shows API call from job
• Check that the PO search does not attempt to fetch a different token
• Disable job
• Wait for job window to pass
• Check that analytics does not show job logs
• Check that analytics does not show API call from job
• Re-enable job

[gina-yamada]

LGTM - Code is well tested, code comments are helpful, refresh enabled defaults to false except for in production

[zachmargolis]

two ideas:

1. what if we broke this into a second statement to avoid some goofy indentation here?
2. what if we used .select(&:present?)

Suggested change

	arcgis_token: (if IdentityConfig.store.arcgis_api_refresh_token_job_enabled
	{
	class: 'ArcgisTokenJob',
	cron: IdentityConfig.store.arcgis_api_refresh_token_job_cron,
	}
	end),
	}.compact
	}
	if IdentityConfig.store.arcgis_api_refresh_token_job_enabled
	config.good_job.cron[:arcgis_token] = {
	class: 'ArcgisTokenJob',
	cron: IdentityConfig.store.arcgis_api_refresh_token_job_cron,
	}
	end

Suggested change

	arcgis_token: (if IdentityConfig.store.arcgis_api_refresh_token_job_enabled
	{
	class: 'ArcgisTokenJob',
	cron: IdentityConfig.store.arcgis_api_refresh_token_job_cron,
	}
	end),
	}.compact
	arcgis_token: {
	class: 'ArcgisTokenJob',
	cron: IdentityConfig.store.arcgis_api_refresh_token_job_cron,
	} && IdentityConfig.store.arcgis_api_refresh_token_job_enabled,
	}.select(&:present?)

[NavaTim]

I was deliberately trying to avoid the second statement you mentioned, though I agree the indentation is goofy.

The .select(&:present?) looks easier to understand, but it doesn't appear to work as shown based on my testing in the Rails console.

[zachmargolis]

ah whoops yes it's this:

> { a: false, b: 1 }.select { |_k, v| v.present? }
=> {:b=>1}