Skip to content

test(estree): ESTree conformance check files with hashbangs #19680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 24, 2026
+9 −20
Merged

test(estree): ESTree conformance check files with hashbangs #19680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/clone-parallel.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const TEST262_SHA = "3aa9cb2c71afc21aefc1f82e899af1d0403351ba";
const BABEL_SHA = "308c8d85b2c81f825f630f765387a135fbf066d9";
const TYPESCRIPT_SHA = "347254895823a36a1b1b1c80471422da54ad77de";
const PRETTIER_SHA = "812a4d0071270f61a7aa549d625b618be7e09d71";
const ESTREE_CONFORMANCE_SHA = "57b0d682b191655b68513165079080943eb279d4";
const ESTREE_CONFORMANCE_SHA = "49d5664fefb9858e29c1d2bec3b631ae09cf8748";
const NODE_COMPAT_TABLE_SHA = "499beb6f1daa36f10c26b85a7f3ec3b3448ded23";

const repoRoot = join(import.meta.dirname, "..", "..");
Expand Down
2 changes: 1 addition & 1 deletion tasks/coverage/snapshots/estree_acorn_jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
commit: 57b0d682
commit: 49d5664f

estree_acorn_jsx Summary:
AST Parsed : 39/39 (100.00%)
Expand Down
2 changes: 1 addition & 1 deletion tasks/coverage/snapshots/estree_acorn_jsx_tokens.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
commit: 57b0d682
commit: 49d5664f

estree_acorn_jsx_tokens Summary:
AST Parsed : 39/39 (100.00%)
Expand Down
4 changes: 2 additions & 2 deletions tasks/coverage/snapshots/estree_test262.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
commit: 3aa9cb2c

estree_test262 Summary:
AST Parsed : 46553/46553 (100.00%)
Positive Passed: 46544/46553 (99.98%)
AST Parsed : 46563/46563 (100.00%)
Positive Passed: 46554/46563 (99.98%)
Mismatch: tasks/coverage/test262/test/language/expressions/assignment/fn-name-lhs-cover.js

Mismatch: tasks/coverage/test262/test/language/expressions/assignment/target-cover-id.js
Expand Down
4 changes: 2 additions & 2 deletions tasks/coverage/snapshots/estree_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
commit: 34725489

estree_typescript Summary:
AST Parsed : 9761/9761 (100.00%)
Positive Passed: 9738/9761 (99.76%)
AST Parsed : 9767/9767 (100.00%)
Positive Passed: 9744/9767 (99.76%)
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/ambientWithStatements.ts
A 'return' statement can only be used within a function body.
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/constDeclarations-invalidContexts.ts
Expand Down
4 changes: 2 additions & 2 deletions tasks/coverage/snapshots/estree_typescript_tokens.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
commit: 34725489

estree_typescript_tokens Summary:
AST Parsed : 9761/9761 (100.00%)
Positive Passed: 9756/9761 (99.95%)
AST Parsed : 9767/9767 (100.00%)
Positive Passed: 9762/9767 (99.95%)
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/ambientWithStatements.ts
A 'return' statement can only be used within a function body.
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/constDeclarations-invalidContexts.ts
Expand Down
11 changes: 0 additions & 11 deletions tasks/coverage/src/tools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,10 +710,6 @@ pub fn run_estree_test262(files: &[Test262File]) -> Vec<CoverageResult> {
if should_fail {
return false;
}
// Skip hashbang tests
if f.path.starts_with("test262/test/language/comments/hashbang/") {
return false;
}
// Skip tests where no Acorn JSON file
let acorn_path = workspace_root()
.join("estree-conformance/tests")
Expand Down Expand Up @@ -937,13 +933,6 @@ static TS_SKIP_PATHS: &[&str] = &[
"typescript/tests/cases/conformance/esDecorators/esDecorators-decoratorExpression.1.ts",
// Skip tests where TS-ESLint is incorrect
"typescript/tests/cases/conformance/es6/templates/templateStringMultiline3.ts",
// Skip tests with hashbangs (we have different handling)
"typescript/tests/cases/compiler/emitBundleWithShebang1.ts",
"typescript/tests/cases/compiler/emitBundleWithShebang2.ts",
"typescript/tests/cases/compiler/emitBundleWithShebangAndPrologueDirectives1.ts",
"typescript/tests/cases/compiler/emitBundleWithShebangAndPrologueDirectives2.ts",
"typescript/tests/cases/compiler/shebang.ts",
"typescript/tests/cases/compiler/shebangBeforeReferences.ts",
];

pub fn run_estree_typescript(files: &[TypeScriptFile]) -> Vec<CoverageResult> {
Expand Down
Loading