Skip to content

chore(submodules): upgrade estree-conformance to latest SHA #19515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camc314 wants to merge 1 commit into from
Closed

chore(submodules): upgrade estree-conformance to latest SHA #19515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions .github/scripts/clone-parallel.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ import { dirname, join } from "node:path";
// NOTE: Prettier version is now pinned to `v3.8.0` (not updated by workflow above), Update manually as needed
const TEST262_SHA = "dd6138f9bc1aa2c3ba9cbf54452049b9a92c4e13";
const BABEL_SHA = "92c052dc449eeb7d9562d5852d1ea295d6c86eca";
const TYPESCRIPT_SHA = "95e3aaa90341b516e868bf2300b1da5d07103f1e";
const TYPESCRIPT_SHA = "ad04bf7488384a5dcdf7d250ccb8e5263021a8ff";
const PRETTIER_SHA = "812a4d0071270f61a7aa549d625b618be7e09d71";
const ESTREE_CONFORMANCE_SHA = "32501475c99fc022a93c80bc6ce1a607f21ecc66";
const ESTREE_CONFORMANCE_SHA = "a12445bbce745fc422d83cf9da23a6c47950f252";
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESTREE_CONFORMANCE_SHA is bumped here, but tasks/coverage/snapshots/estree_acorn_jsx.snap still has commit: 32501475 (old estree-conformance short SHA). Snapshot::save asserts when the snapshot file’s commit: header doesn’t match the checked-out repo SHA, so this will fail unless that snapshot header is updated/regenerated for the new estree-conformance commit.

Suggested change
const ESTREE_CONFORMANCE_SHA = "a12445bbce745fc422d83cf9da23a6c47950f252";
const ESTREE_CONFORMANCE_SHA = "32501475";

Copilot uses AI. Check for mistakes.
const NODE_COMPAT_TABLE_SHA = "499beb6f1daa36f10c26b85a7f3ec3b3448ded23";

const repoRoot = join(import.meta.dirname, "..", "..");
Expand Down Expand Up @@ -95,7 +95,16 @@ async function cloneRepo(shouldClone, repo, path, ref, name) {
} else {
// Directory doesn't exist - clone it
await runGit(
["clone", "--quiet", "--no-progress", "--single-branch", "--depth", "1", repoUrl, fullPath],
[
"clone",
"--quiet",
"--no-progress",
"--single-branch",
"--depth",
"1",
repoUrl,
fullPath,
],
repoRoot,
);
}
Expand All @@ -115,7 +124,9 @@ async function cloneRepo(shouldClone, repo, path, ref, name) {
console.log(`[OK] Completed clone of ${name}`);
return { success: true, name };
} catch (error) {
console.error(`[FAILED] Clone operation failed for ${name}: ${error.message}`);
console.error(
`[FAILED] Clone operation failed for ${name}: ${error.message}`,
);
return { success: false, name, error: error.message };
}
}
Expand All @@ -125,7 +136,13 @@ async function main() {

// Start all clone operations in parallel
const results = await Promise.all([
cloneRepo(TEST262, "tc39/test262", "tasks/coverage/test262", TEST262_SHA, "test262"),
cloneRepo(
TEST262,
"tc39/test262",
"tasks/coverage/test262",
TEST262_SHA,
"test262",
),
cloneRepo(BABEL, "babel/babel", "tasks/coverage/babel", BABEL_SHA, "babel"),
cloneRepo(
TYPESCRIPT,
Expand Down
6 changes: 3 additions & 3 deletions tasks/coverage/snapshots/codegen_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
commit: 95e3aaa9
commit: ad04bf74

codegen_typescript Summary:
AST Parsed : 9840/9840 (100.00%)
Positive Passed: 9840/9840 (100.00%)
AST Parsed : 9834/9834 (100.00%)
Positive Passed: 9834/9834 (100.00%)
2 changes: 1 addition & 1 deletion tasks/coverage/snapshots/estree_acorn_jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
commit: 32501475
commit: a12445bb

estree_acorn_jsx Summary:
AST Parsed : 39/39 (100.00%)
Expand Down
34 changes: 33 additions & 1 deletion tasks/coverage/snapshots/estree_test262.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,39 @@ commit: dd6138f9

estree_test262 Summary:
AST Parsed : 46490/46490 (100.00%)
Positive Passed: 46481/46490 (99.98%)
Positive Passed: 46465/46490 (99.95%)
Mismatch: tasks/coverage/test262/test/intl402/DateTimeFormat/prototype/formatToParts/era.js

Mismatch: tasks/coverage/test262/test/intl402/PluralRules/prototype/selectRange/argument-tonumber-throws.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/chinese-30-day-leap-months.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/chinese-leap-month-codes-common.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/chinese-month-codes.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/coptic-month-codes.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/dangi-leap-month-codes-common.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/dangi-month-codes.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/ethioaa-month-codes.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/ethiopic-month-codes.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/hebrew-month-codes.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/indian-month-codes.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/islamic-civil-month-codes.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/islamic-tbla-month-codes.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/islamic-umalqura-month-codes.js

Mismatch: tasks/coverage/test262/test/intl402/Temporal/PlainMonthDay/from/persian-month-codes.js

Mismatch: tasks/coverage/test262/test/language/expressions/assignment/fn-name-lhs-cover.js

Mismatch: tasks/coverage/test262/test/language/expressions/assignment/target-cover-id.js
Expand Down
16 changes: 13 additions & 3 deletions tasks/coverage/snapshots/estree_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
commit: 95e3aaa9
commit: ad04bf74

estree_typescript Summary:
AST Parsed : 9773/9773 (100.00%)
Positive Passed: 9755/9773 (99.82%)
AST Parsed : 9761/9761 (100.00%)
Positive Passed: 9738/9761 (99.76%)
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/ambientWithStatements.ts
A 'return' statement can only be used within a function body.
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/constDeclarations-invalidContexts.ts
Lexical declaration cannot appear in a single-statement context
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/constDeclarations-scopes.ts
Lexical declaration cannot appear in a single-statement context
Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/constDeclarations-validContexts.ts
Lexical declaration cannot appear in a single-statement context
Mismatch: tasks/coverage/typescript/tests/cases/compiler/moduleDetectionIsolatedModulesCjsFileScope.ts

Mismatch: tasks/coverage/typescript/tests/cases/compiler/moduleNodeImportRequireEmit.ts
Expand Down Expand Up @@ -39,3 +47,5 @@ Mismatch: tasks/coverage/typescript/tests/cases/conformance/node/esmModuleExport

Mismatch: tasks/coverage/typescript/tests/cases/conformance/nonjsExtensions/declarationFilesForNodeNativeModules.ts

Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmascript5/ErrorRecovery/parserStatementIsNotAMemberVariableDeclaration1.ts
A 'return' statement can only be used within a function body.
6 changes: 3 additions & 3 deletions tasks/coverage/snapshots/formatter_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
commit: 95e3aaa9
commit: ad04bf74

formatter_typescript Summary:
AST Parsed : 9840/9840 (100.00%)
Positive Passed: 9788/9840 (99.47%)
AST Parsed : 9834/9834 (100.00%)
Positive Passed: 9782/9834 (99.47%)
Mismatch: tasks/coverage/typescript/tests/cases/compiler/amdLikeInputDeclarationEmit.ts

Mismatch: tasks/coverage/typescript/tests/cases/compiler/castExpressionParentheses.ts
Expand Down
Loading
Loading