Don't snapshot on monitor goroutine or Raft node quit signal unless shutting down#7495
Merged
neilalexander merged 1 commit intomainfrom Oct 30, 2025
Merged
Don't snapshot on monitor goroutine or Raft node quit signal unless shutting down#7495neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
neilalexander
force-pushed
the
neil/qchsnapshot
branch
from
b602b50 to
5475586
Compare
…hutting down Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/qchsnapshot
branch
from
5475586 to
0a1bc4d
Compare
MauriceVanVeen
approved these changes
Oct 30, 2025
neilalexander
added a commit
that referenced
this pull request
Oct 30, 2025
neilalexander
added a commit
that referenced
this pull request
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #6279 we introduced attempting snapshots on shutdown, but some of these branches would snapshot regardless of whether we're actually shutting down or not, i.e. for assets that are either about to go away (i.e. due to being deleted or scaled down on a given node).
Signed-off-by: Neil Twigg neil@nats.io