Skip to content

[FIXED] Parallel stream restore panic#7503

Merged
neilalexander merged 1 commit intomainfrom
maurice/ats-panic
Nov 3, 2025
Merged

[FIXED] Parallel stream restore panic#7503
neilalexander merged 1 commit intomainfrom
maurice/ats-panic

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

Due to the stream restore parallelization introduced in #7482, we can panic on access time service not running. Since ats.Register() can now be called in parallel as well.

We can simply store an initial value, on startup it's no issue that this timestamp is only slightly stale.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner November 3, 2025 09:48
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@neilalexander neilalexander merged commit 48a4477 into main Nov 3, 2025
130 of 136 checks passed
@neilalexander neilalexander deleted the maurice/ats-panic branch November 3, 2025 16:38
neilalexander added a commit that referenced this pull request Nov 5, 2025
Includes the following:

- #7499
- #7503
- #7508
- #7510
- #7509
- #7512
- #7516
- #7515

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Nov 5, 2025
Includes the following:

- #7416
- #7425
- #7486
- #7495
- #7482
- #7496
- #7499
- #7503
- #7508 (excluding weak
pointer/cache-related changes that apply only to 2.12.x)
- #7510
- #7509
- #7512
- #7516
- #7515

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants