Re-introduce stream/consumer snapshot on shutdown#6279
Merged
derekcollison merged 1 commit intomainfrom Dec 18, 2024
Merged
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander
added a commit
that referenced
this pull request
Jun 4, 2025
When shutting down the stream would not be snapshotted. Either the monitor would close first and `doSnapshot` would not be called, or there would be a race with the Raft node being stopped and `InstallSnapshot` becoming a no-op. Relates to #6279 Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander
added a commit
that referenced
this pull request
Oct 30, 2025
…hutting down (#7495) In #6279 we introduced attempting snapshots on shutdown, but some of these branches would snapshot regardless of whether we're actually shutting down or not, i.e. for assets that are either about to go away (i.e. due to being deleted or scaled down on a given node). Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the race condition of installing snapshots during shutdown was fixed in #6153, we have not re-introduced this snapshotting but done in the right place. (Meta already has this)
Signed-off-by: Maurice van Veen github@mauricevanveen.com