[IMPROVED] Filestore MaxBytes/Msgs update performance#7455
Merged
neilalexander merged 1 commit intomainfrom Oct 21, 2025
Merged
[IMPROVED] Filestore MaxBytes/Msgs update performance#7455neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/fs-max-limit
branch
from
3716fdb to
2064735
Compare
neilalexander
added a commit
that referenced
this pull request
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a stream would be updated from a high
MaxBytes/MaxMsgsand then lowered such that many messages and blocks need to be purged, the server would walk over all individual sequences and remove them one-by-one. Instead, if the full block can be removed then loads of bytes/messages can be removed all at once. This speeds up discarding many old messages, especially when many gigabytes of data needs to be removed since we'll not need to load the messages into memory to remove them.Resolves #7450
Signed-off-by: Maurice van Veen github@mauricevanveen.com