Skip to content

Cherry-picks for v2.12.2-RC.1#7497

Merged
neilalexander merged 24 commits intorelease/v2.12.2from
backports/v2.12.2-RC.1
Oct 30, 2025
Merged

Cherry-picks for v2.12.2-RC.1#7497
neilalexander merged 24 commits intorelease/v2.12.2from
backports/v2.12.2-RC.1

Conversation

neilalexander and others added 2 commits October 30, 2025 15:30
The first load of the last sequence via `firstMatching` or `firstMatchingMulti`
will still continue to flag `expireOk`, as though we're optimising for the linear
scan case, but if it becomes apparent that we are continuously reloading the same
last sequence over and over again in this way, don't set `expireOk` or we'll just
keep expiring and reloading the cache each time.

Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Michael Röschter <michael@roeschter.de>
@neilalexander neilalexander requested a review from a team as a code owner October 30, 2025 15:54
Copy link
Copy Markdown
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MauriceVanVeen and others added 22 commits October 30, 2025 16:19
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Setting the "hop" header for each gateway could cause header
corruption. This is now fixed.

A test dealing with gateway has been improved to include more than
one gateway, which would have demonstrated the issue. The test now
passes and ensures that the hop is different per gateway.

Related to #7442

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Saw the test TestConfigCheck flap. The reason is that the proxy
validation was done when parsing the "proxy" field, but there was
no guarantee that this field would be parsed after "urls", which
may lead to validation being successful (because there was no
URLs added yet). Move the check after all fields have been parsed
for a given remote.

Relates to #7242

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
…messages

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Alex Bozhenko <alexbozhenko@gmail.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
…snapshotting

Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
…hutting down

Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@neilalexander neilalexander force-pushed the backports/v2.12.2-RC.1 branch from 8616e47 to b786da5 Compare October 30, 2025 16:19
@neilalexander neilalexander merged commit 047a04e into release/v2.12.2 Oct 30, 2025
131 of 136 checks passed
@neilalexander neilalexander deleted the backports/v2.12.2-RC.1 branch October 30, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants