Skip to content

[FIXED] Recreated stream/consumer meta snapshot consistency#7510

Merged
neilalexander merged 1 commit intomainfrom
maurice/recover-snap-recreated
Nov 5, 2025
Merged

[FIXED] Recreated stream/consumer meta snapshot consistency#7510
neilalexander merged 1 commit intomainfrom
maurice/recover-snap-recreated

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

If a stream and consumer exists in a meta snapshot, the stream was deleted and then recreated with a different config.. This would result in monitorStream and monitorConsumer running with a Raft node running under the deleted group, which makes it not function properly.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/recover-snap-recreated branch from 039dc8f to 4a6eba1 Compare November 5, 2025 09:22
@MauriceVanVeen MauriceVanVeen marked this pull request as ready for review November 5, 2025 09:23
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner November 5, 2025 09:23
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 73e2e37 into main Nov 5, 2025
90 of 92 checks passed
@neilalexander neilalexander deleted the maurice/recover-snap-recreated branch November 5, 2025 09:57
neilalexander added a commit that referenced this pull request Nov 5, 2025
Includes the following:

- #7499
- #7503
- #7508
- #7510
- #7509
- #7512
- #7516
- #7515

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Nov 5, 2025
Includes the following:

- #7416
- #7425
- #7486
- #7495
- #7482
- #7496
- #7499
- #7503
- #7508 (excluding weak
pointer/cache-related changes that apply only to 2.12.x)
- #7510
- #7509
- #7512
- #7516
- #7515

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Nov 7, 2025
Follow-up of #7510. If a
consumer existed in the meta snapshot but was deleted as part of the
recovery, it would "re-appear" in the health check and result in a
`consumer not found` error.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants