Skip to content

Offline assets: Improve error reporting/logging#7416

Merged
neilalexander merged 1 commit intomainfrom
neil/strictdecode
Oct 10, 2025
Merged

Offline assets: Improve error reporting/logging#7416
neilalexander merged 1 commit intomainfrom
neil/strictdecode

Conversation

@neilalexander
Copy link
Copy Markdown
Member

This improves the error logging for offline assets to:

  • Report the same API level errors on the API responses and the log
  • Report which specific config fields were invalid or unexpected
  • Report which consumers caused a stream to be stopped

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander neilalexander requested a review from a team as a code owner October 10, 2025 15:41
Signed-off-by: Neil Twigg <neil@nats.io>
Copy link
Copy Markdown
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit d1bf5a7 into main Oct 10, 2025
89 of 92 checks passed
@neilalexander neilalexander deleted the neil/strictdecode branch October 10, 2025 16:26
neilalexander added a commit that referenced this pull request Oct 13, 2025
Follow-up of #7416, the
`strictErr` should be used. Not `err` which was used for different
errors.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
neilalexander added a commit that referenced this pull request Oct 13, 2025
Includes the following:

- #7416
- #7423
- #7425
- #7424
- #7411

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Nov 5, 2025
Includes the following:

- #7416
- #7425
- #7486
- #7495
- #7482
- #7496
- #7499
- #7503
- #7508 (excluding weak
pointer/cache-related changes that apply only to 2.12.x)
- #7510
- #7509
- #7512
- #7516
- #7515

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants