Skip to content

[TEST] Add assert.Unreachable when using legacy JSON stream snapshot#7486

Merged
neilalexander merged 1 commit intomainfrom
maurice/assert-legacy-snap
Oct 29, 2025
Merged

[TEST] Add assert.Unreachable when using legacy JSON stream snapshot#7486
neilalexander merged 1 commit intomainfrom
maurice/assert-legacy-snap

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

@MauriceVanVeen MauriceVanVeen commented Oct 29, 2025

Closes #7485.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/assert-legacy-snap branch from 422c410 to 3aa9414 Compare October 29, 2025 09:30
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit b94011e into main Oct 29, 2025
68 of 70 checks passed
@neilalexander neilalexander deleted the maurice/assert-legacy-snap branch October 29, 2025 09:58
neilalexander added a commit that referenced this pull request Oct 30, 2025
Includes the following:

- #7435
- #7433
- #7436
- #7443
- #7440
- #7444
- #7452
- #7455
- #7458
- #7465
- #7466
- #7474
- #7469
- #7460
- #7449
- #7484
- #7479
- #7486
- #7495
- #7482
- #7496

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Nov 5, 2025
Includes the following:

- #7416
- #7425
- #7486
- #7495
- #7482
- #7496
- #7499
- #7503
- #7508 (excluding weak
pointer/cache-related changes that apply only to 2.12.x)
- #7510
- #7509
- #7512
- #7516
- #7515

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants