Skip to content

[FIXED] Message Tracing: Hop header set properly per gateway#7443

Merged
neilalexander merged 1 commit intomainfrom
fix_msg_trace_gw_hop
Oct 19, 2025
Merged

[FIXED] Message Tracing: Hop header set properly per gateway#7443
neilalexander merged 1 commit intomainfrom
fix_msg_trace_gw_hop

Conversation

@kozlovic
Copy link
Copy Markdown
Member

Setting the "hop" header for each gateway could cause header corruption. This is now fixed.

A test dealing with gateway has been improved to include more than one gateway, which would have demonstrated the issue. The test now passes and ensures that the hop is different per gateway.

Related to #7442

Signed-off-by: Ivan Kozlovic ivan@synadia.com

Setting the "hop" header for each gateway could cause header
corruption. This is now fixed.

A test dealing with gateway has been improved to include more than
one gateway, which would have demonstrated the issue. The test now
passes and ensures that the hop is different per gateway.

Related to #7442

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from a team as a code owner October 18, 2025 17:51
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit d50748c into main Oct 19, 2025
90 of 92 checks passed
@neilalexander neilalexander deleted the fix_msg_trace_gw_hop branch October 19, 2025 16:09
@johnweldon
Copy link
Copy Markdown
Member

Will this patch be included in a 2.11 release?

@MauriceVanVeen
Copy link
Copy Markdown
Member

Will this patch be included in a 2.11 release?

Yeah, 2.11.x and 2.12.x

neilalexander added a commit that referenced this pull request Oct 28, 2025
Includes the following:

- #7380
- #7384
- #7385
- #7388
- #7395
- #7400
- #7399
- #7401
- #7402
- #7423
- #7424
- #7411
- #7428
- #7429
- #7431
- #7435
- #7433
- #7443
- #7455
- #7465
- #7466
- #7460
- #7484
- #7479

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Oct 30, 2025
Includes the following:

- #7435
- #7433
- #7436
- #7443
- #7440
- #7444
- #7452
- #7455
- #7458
- #7465
- #7466
- #7474
- #7469
- #7460
- #7449
- #7484
- #7479
- #7486
- #7495
- #7482
- #7496

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants