Skip to content

[IMPROVED] Implicit RePublish based on SubjectTransform#7515

Merged
neilalexander merged 1 commit intomainfrom
maurice/implicit-repub
Nov 5, 2025
Merged

[IMPROVED] Implicit RePublish based on SubjectTransform#7515
neilalexander merged 1 commit intomainfrom
maurice/implicit-repub

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

If the stream configuration contains stream subject a.>, subject transform a.> to b.> and republish > to >, this currently errors containing a cycle. However, the intention behind this is that the transformed b.> subject is RePublished. This PR now allows this, but only if this link is preserved. Specifically only allowing if the stream has a single subject and the transform maps only that subject. This is a non-breaking change since this used to be an error before, and mostly allows to not need to repeat the transformed subject of b.> two more times in the source/destination of the RePublish.

Put simply, the RePublish of > to > gets transformed to a source of b.> and destination of b.> given the prerequisites.

Resolves #7511

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner November 5, 2025 13:43
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 60a276b into main Nov 5, 2025
68 of 70 checks passed
@neilalexander neilalexander deleted the maurice/implicit-repub branch November 5, 2025 14:14
neilalexander added a commit that referenced this pull request Nov 5, 2025
Includes the following:

- #7499
- #7503
- #7508
- #7510
- #7509
- #7512
- #7516
- #7515

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Nov 5, 2025
Includes the following:

- #7416
- #7425
- #7486
- #7495
- #7482
- #7496
- #7499
- #7503
- #7508 (excluding weak
pointer/cache-related changes that apply only to 2.12.x)
- #7510
- #7509
- #7512
- #7516
- #7515

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't use subject_transform and republish the resulting transformed message

2 participants