Skip to content

[FIXED] Consumer send 404 No Messages on EOS#7466

Merged
neilalexander merged 2 commits intomainfrom
maurice/no-wait-eos
Oct 24, 2025
Merged

[FIXED] Consumer send 404 No Messages on EOS#7466
neilalexander merged 2 commits intomainfrom
maurice/no-wait-eos

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

@MauriceVanVeen MauriceVanVeen commented Oct 23, 2025 •
edited
Loading

Requests using NoWait but no expiry would not receive 404 No Messages if the stream was empty and no messages were delivered. 408 Request Timeout would only be returned if messages were delivered or the request expired.

This PR fixes that by sending a 404 No Messages for NoWait requests without expiry (same response when doing a pull request on a consumer with no pending messages) when reaching the end of the stream.

Resolves #7457, #5373

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen
[FIXED] Consumer send 404 No Messages on EOS
7d6b0a8 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner October 23, 2025 12:40
@wallyqs
Copy link
Copy Markdown
Member

wallyqs commented Oct 23, 2025

maybe also fixes? #5373

@MauriceVanVeen
Copy link
Copy Markdown
Member Author

MauriceVanVeen commented Oct 23, 2025 •
edited
Loading

maybe also fixes? #5373

The current commit would not, but this added commit will: b5b86fb

Reserving that one for 2.14 though since that's a behavior change. Whereas without the original fix the server would not respond to the client at all if it didn't deliver messages.

@MauriceVanVeen
(2.14) [FIXED] Consumer send 404 No Messages on EOS after delivering …
b5b86fb 
…messages

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen linked an issue Oct 23, 2025 that may be closed by this pull request
'408 Request Timeout' instead of '404 No Messages' from $JS.API.CONSUMER.MSG.NEXT.<stream>.<consumer> [v2.10.14] #5373
Closed
neilalexander
neilalexander approved these changes Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 85594c8 into main Oct 24, 2025
67 of 71 checks passed
@neilalexander neilalexander deleted the maurice/no-wait-eos branch October 24, 2025 09:58
@neilalexander neilalexander mentioned this pull request Oct 28, 2025
Merged
neilalexander added a commit that referenced this pull request Oct 28, 2025
@neilalexander
Cherry-picks for v2.11.11-RC.1 (#7480)
2c24fea 
Includes the following:

- #7380
- #7384
- #7385
- #7388
- #7395
- #7400
- #7399
- #7401
- #7402
- #7423
- #7424
- #7411
- #7428
- #7429
- #7431
- #7435
- #7433
- #7443
- #7455
- #7465
- #7466
- #7460
- #7484
- #7479

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander mentioned this pull request Oct 30, 2025
Merged
neilalexander added a commit that referenced this pull request Oct 30, 2025
@neilalexander
Cherry-picks for v2.12.2-RC.1 (#7497)
047a04e 
Includes the following:

- #7435
- #7433
- #7436
- #7443
- #7440
- #7444
- #7452
- #7455
- #7458
- #7465
- #7466
- #7474
- #7469
- #7460
- #7449
- #7484
- #7479
- #7486
- #7495
- #7482
- #7496

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@MauriceVanVeen @wallyqs @neilalexander