[TEST] Add assert.Unreachable when unmarshalling legacy JSON stream snapshot#7498
Closed
alexbozhenko wants to merge 1 commit intomainfrom
Closed
[TEST] Add assert.Unreachable when unmarshalling legacy JSON stream snapshot#7498alexbozhenko wants to merge 1 commit intomainfrom
alexbozhenko wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Alex Bozhenko <alexbozhenko@gmail.com>
Member
Author
|
@MauriceVanVeen Do I understand correctly that this place also should not be reachable? |
Member
|
It wouldn't be possible to reach this in Antithesis without having already triggered the other assert, so don't think this is needed. |
Member
|
Indeed this is in essence redundant. The snapshot needs to be created before it can be unmarshalled. And it's more useful to only fail on the server that creates it, than also on a follower that might receive it as a result. The legacy snapshot code also will need to remain, as otherwise it can break existing deployments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7486
Signed-off-by: Alex Bozhenko alexbozhenko@gmail.com