Skip to content

[FIXED] Successful exit code during shutdown#7367

Merged
neilalexander merged 1 commit intomainfrom
maurice/non-fatal-sigterm
Sep 29, 2025
Merged

[FIXED] Successful exit code during shutdown#7367
neilalexander merged 1 commit intomainfrom
maurice/non-fatal-sigterm

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

Antithesis can reproduce a non-zero exit code if during startup we immediately get SIGTERM-ed. This is because initialization isn't completed yet when the SIGTERM comes in. We can simply not do a Fatal log. Turning it into an error log instead ensures we don't exit with an unexpected exit code.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner September 29, 2025 08:23
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 7ebfbdd into main Sep 29, 2025
48 checks passed
@neilalexander neilalexander deleted the maurice/non-fatal-sigterm branch September 29, 2025 08:58
neilalexander added a commit that referenced this pull request Sep 29, 2025
Includes the following:

- #7290
- #7295
- #7291
- #7287
- #7299
- #7300
- #7297
- #7303
- #7304
- #7305
- #7309
- #7307
- #7320
- #7337
- #7344
- #7345
- #7348
- #7349
- #7350
- #7357
- #7356
- #7358
- #7367
- #7293

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Sep 29, 2025
Includes the following:

- #7337
- #7342
- #7344
- #7345
- #7347
- #7346
- #7348
- #7349
- #7350
- #7357
- #7356
- #7358
- #7359
- #7366
- #7367
- #7293
- #7368

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants