Merged
Conversation
Member
neilalexander
left a comment
neilalexander
left a comment
There was a problem hiding this comment.
v2.11.8:
goos: darwin
goarch: arm64
pkg: github.com/nats-io/nats-server/v2/server
cpu: Apple M2 Ultra
BenchmarkJetStreamMetaSnapshot
BenchmarkJetStreamMetaSnapshot/Default
BenchmarkJetStreamMetaSnapshot/Default-24 4 251366969 ns/op
BenchmarkJetStreamMetaSnapshot/AllUnsupported
BenchmarkJetStreamMetaSnapshot/AllUnsupported-24 5 206466767 ns/op
PASS
ok github.com/nats-io/nats-server/v2/server 148.689s
v2.11.9:
goos: darwin
goarch: arm64
pkg: github.com/nats-io/nats-server/v2/server
cpu: Apple M2 Ultra
BenchmarkJetStreamMetaSnapshot
BenchmarkJetStreamMetaSnapshot/Default
BenchmarkJetStreamMetaSnapshot/Default-24 2 714755854 ns/op
BenchmarkJetStreamMetaSnapshot/AllUnsupported
BenchmarkJetStreamMetaSnapshot/AllUnsupported-24 2 573180208 ns/op
PASS
ok github.com/nats-io/nats-server/v2/server 93.172s
This PR on top of main:
goos: darwin
goarch: arm64
pkg: github.com/nats-io/nats-server/v2/server
cpu: Apple M2 Ultra
BenchmarkJetStreamMetaSnapshot
BenchmarkJetStreamMetaSnapshot/Default
BenchmarkJetStreamMetaSnapshot/Default-24 4 250398781 ns/op
BenchmarkJetStreamMetaSnapshot/AllUnsupported
BenchmarkJetStreamMetaSnapshot/AllUnsupported-24 5 214635150 ns/op
PASS
ok github.com/nats-io/nats-server/v2/server 80.426s
| js.mu.Unlock() | ||
|
|
||
| // Wait for all servers to have created all assets. | ||
| checkFor(b, 20*time.Second, 200*time.Millisecond, func() error { |
Member
There was a problem hiding this comment.
I had to up this to 60*time.Second in order to make the test more reliable on my machine.
Member
There was a problem hiding this comment.
Actually switching to Storage: MemoryStorage for streams and MemoryStorage: true for consumers speeds up the setup considerably.
Member
Author
There was a problem hiding this comment.
Changed to memory storage
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/bench-meta-snap
branch
from
815980b to
37abf29
Compare
neilalexander
added a commit
that referenced
this pull request
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folow-up of #7350
Signed-off-by: Maurice van Veen github@mauricevanveen.com