Cherry-picks for v2.11.10-RC.1#7370
Merged
neilalexander merged 31 commits intorelease/v2.11.10from Sep 29, 2025
Merged
Conversation
Remove misleading comment for the loop at the end of isStreamAssigned: "Check if we are the leader of this raftGroup [...]". This code is checking for membership, not leadership of the group. Instead of fixing the comment, replace the whole loop with a call to isMember. Same for isConsumerAssigned. Signed-off-by: Daniele Sciascia <daniele@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
…ate cache in `loadMsgsWithLock` Signed-off-by: Neil Twigg <neil@nats.io>
…sages are skipped over. This fixes/extends this so it also applies if the requested sequence number happens to be deleted. Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
This is a non-functional change. Removed the receiver `(n *raft)` from decodeAppendEntry since it does not depend on raft state. Same for decodeAppendEntryResponse. Signed-off-by: Daniele Sciascia <daniele@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
This was introduced in #6967 to support gateway, route, and leaf stats. However the DataStats type is used for client connection stats (e.g. disconnect event) for which the additional fields are not relevant. Having a pointer ensures the omitempty JSON tag is respected and those nil fields are not serialized. Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
…ible Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Alex Bozhenko <alexbozhenko@gmail.com>
Signed-off-by: Alex Bozhenko <alexbozhenko@gmail.com>
Signed-off-by: Neil Twigg <neil@nats.io>
- Corrected minor typos in leafnode.go - Included empty commit to trigger CI rerun Signed-off-by: Yoonseo Han <yooncer00@gmail.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
… with partial wildcards Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes the following:
msgFromBufEx#7299Signed-off-by: Neil Twigg neil@nats.io