Merged
Conversation
Signed-off-by: Alex Bozhenko <alexbozhenko@gmail.com>
12d980c to
841b4e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (but not arm64) is broken on windows.
Latest Goreleaser(2.12) started to complain about this:
Support is to be removed from Golang. Stop building for ARM on Windows
golang/go#70705
https://go.dev/wiki/GoArm
goreleaser/goreleaser#5951
https://golang.google.cn/doc/go1.24#windows
https://golang.google.cn/doc/go1.25#windows
Also, judging by the number of downlads,
it looks like only automated scripts and not real people download those builds.
https://somsubhra.github.io/github-release-stats/?username=nats-io&repository=nats-server
Test plan:
Signed-off-by: Alex Bozhenko alexbozhenko@gmail.com