Skip to content

(2.12) Deactivate message schedule on missing header#7366

Merged
neilalexander merged 1 commit intomainfrom
maurice/no-sched-deactivate
Sep 29, 2025
Merged

(2.12) Deactivate message schedule on missing header#7366
neilalexander merged 1 commit intomainfrom
maurice/no-sched-deactivate

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

When a schedule is published on a subject foo.schedule, if another message is published under the same subject but it is not a schedule then the schedule should be deactivated.

The ADR describes "the last message on a subject holds the current schedule", which means it would be unexpected if a schedule doesn't get deactivated if it's not the last message for that subject anymore.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner September 29, 2025 08:06
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 495aa36 into main Sep 29, 2025
48 checks passed
@neilalexander neilalexander deleted the maurice/no-sched-deactivate branch September 29, 2025 08:57
neilalexander added a commit that referenced this pull request Sep 29, 2025
Includes the following:

- #7337
- #7342
- #7344
- #7345
- #7347
- #7346
- #7348
- #7349
- #7350
- #7357
- #7356
- #7358
- #7359
- #7366
- #7367
- #7293
- #7368

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants