[FIXED] Reset clustered state on msg delete EOF#7348
Merged
neilalexander merged 1 commit intomainfrom Sep 24, 2025
Merged
Conversation
server/jetstream_cluster.go
Outdated
|
|
||
| // Cluster reset error. | ||
| js.mu.RLock() | ||
| isLeader := cc.isStreamLeader(md.Client.serviceAccount(), md.Stream) |
Member
There was a problem hiding this comment.
This seems expensive for the hotpath IMO..
Member
Author
There was a problem hiding this comment.
Done, now using node := mset.raftNode(); node != nil && node.Leader()
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/rm-eof
branch
from
08e91f9 to
f32e518
Compare
neilalexander
added a commit
that referenced
this pull request
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a non-existent sequence on a stream results in clustered state being reset, which triggers a leader election.
Resolves #7308
Signed-off-by: Maurice van Veen github@mauricevanveen.com