Skip to content

[FIXED] Data race on JetStream reserved limits#7356

Merged
neilalexander merged 1 commit intomainfrom
maurice/js-limit-lock
Sep 26, 2025
Merged

[FIXED] Data race on JetStream reserved limits#7356
neilalexander merged 1 commit intomainfrom
maurice/js-limit-lock

Conversation

@MauriceVanVeen
Copy link
Copy Markdown
Member

JS read lock was not held upon calling jsa.js.checkAllLimits.

Resolves #7288

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner September 25, 2025 14:16
Copy link
Copy Markdown
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit f6a62d7 into main Sep 26, 2025
90 of 92 checks passed
@neilalexander neilalexander deleted the maurice/js-limit-lock branch September 26, 2025 10:51
neilalexander added a commit that referenced this pull request Sep 29, 2025
Includes the following:

- #7290
- #7295
- #7291
- #7287
- #7299
- #7300
- #7297
- #7303
- #7304
- #7305
- #7309
- #7307
- #7320
- #7337
- #7344
- #7345
- #7348
- #7349
- #7350
- #7357
- #7356
- #7358
- #7367
- #7293

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Sep 29, 2025
Includes the following:

- #7337
- #7342
- #7344
- #7345
- #7347
- #7346
- #7348
- #7349
- #7350
- #7357
- #7356
- #7358
- #7359
- #7366
- #7367
- #7293
- #7368

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JetStream data-race between checkBytesLimits() and reserveStreamResources() [v2.11.3]

2 participants