[FIXED] Restore non-ordered sequences in filestore msg blocks#7303
Merged
neilalexander merged 1 commit intomainfrom Sep 12, 2025
Merged
[FIXED] Restore non-ordered sequences in filestore msg blocks#7303neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
MauriceVanVeen
force-pushed
the
maurice/fs-corrupt-seq
branch
from
d827a94 to
e8cb6b7
Compare
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/fs-corrupt-seq
branch
from
e8cb6b7 to
bab157e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a message block was loaded, either through
rebuildStateorindexCacheBuf, it would not recover properly if the block was corrupted in some way and the sequences were not ordered (like seq 1, 3, 2, 4). This would both mark message 2 as deleted, and then mark message 3 as deleted when sequence 4 is encountered.This fixes both recovery paths to only mark message 2 as deleted, and then skip over it. Or more generally, skip over any sequences that are lower than the highest sequence we've encountered last.
Signed-off-by: Maurice van Veen github@mauricevanveen.com